Merge tips

Author: VincentLanglet

src/Rules/Comparison/ImpossibleCheckTypeFunctionCallRule.php

@@ -49,7 +49,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$addTip = function (RuleErrorBuilder $ruleErrorBuilder) use ($scope, $node, $reasons): RuleErrorBuilder {
 			if (count($reasons) > 0) {
-				return $ruleErrorBuilder->acceptsReasonsTip($reasons);
+				$ruleErrorBuilder->acceptsReasonsTip($reasons);
 			}
 
 			if (!$this->treatPhpDocTypesAsCertain) {

src/Rules/Comparison/ImpossibleCheckTypeMethodCallRule.php

@@ -47,7 +47,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$addTip = function (RuleErrorBuilder $ruleErrorBuilder) use ($scope, $node, $reasons): RuleErrorBuilder {
 			if (count($reasons) > 0) {
-				return $ruleErrorBuilder->acceptsReasonsTip($reasons);
+				$ruleErrorBuilder->acceptsReasonsTip($reasons);
 			}
 
 			if (!$this->treatPhpDocTypesAsCertain) {

src/Rules/Comparison/ImpossibleCheckTypeStaticMethodCallRule.php

@@ -47,7 +47,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$addTip = function (RuleErrorBuilder $ruleErrorBuilder) use ($scope, $node, $reasons): RuleErrorBuilder {
 			if (count($reasons) > 0) {
-				return $ruleErrorBuilder->acceptsReasonsTip($reasons);
+				$ruleErrorBuilder->acceptsReasonsTip($reasons);
 			}
 
 			if (!$this->treatPhpDocTypesAsCertain) {

src/Rules/Comparison/StrictComparisonOfDifferentTypesRule.php

@@ -56,7 +56,7 @@ public function processNode(Node $node, Scope $scope): array
 		$addTip = function (RuleErrorBuilder $ruleErrorBuilder) use ($scope, $node, $nodeTypeResult): RuleErrorBuilder {
 			$reasons = $nodeTypeResult->reasons;
 			if (count($reasons) > 0) {
-				return $ruleErrorBuilder->acceptsReasonsTip($reasons);
+				$ruleErrorBuilder->acceptsReasonsTip($reasons);
 			}
 
 			if (!$this->treatPhpDocTypesAsCertain) {

src/Rules/RuleErrorBuilder.php

@@ -208,7 +208,7 @@ public function acceptsReasonsTip(array $reasons): self
 	 */
 	public function treatPhpDocTypesAsCertainTip(): self
 	{
-		return $this->tip('Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.');
+		return $this->addTip('Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.');
 	}
 
 	/**