fixup! Add MemoizationPropertyRule

Author: zonuexe

build/PHPStan/Build/MemoizationPropertyRule.php

@@ -8,6 +8,7 @@
 use PhpParser\Node\Expr\BinaryOp\Identical;
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\PropertyFetch;
+use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\If_;
@@ -19,7 +20,6 @@
 use PHPStan\Rules\RuleErrorBuilder;
 use function count;
 use function dirname;
-use function get_class;
 use function sprintf;
 use function str_starts_with;
 use function strcasecmp;
@@ -52,9 +52,10 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		[$ifNode, $returnNode] = $stmts;
-
-		if (!$returnNode instanceof Return_ ||
-			!$returnNode->expr instanceof PropertyFetch
+		if (!$returnNode instanceof Return_
+			|| !$returnNode->expr instanceof PropertyFetch
+			|| !$returnNode->expr->var instanceof Variable
+			|| !$returnNode->expr->name instanceof Identifier
 		) {
 			return [];
 		}
@@ -66,22 +67,20 @@ public function processNode(Node $node, Scope $scope): array
 			|| $ifNode->else !== null
 			|| !$ifNode->cond instanceof Identical
 			|| !$ifNode->cond->left instanceof PropertyFetch
+			|| !$ifNode->cond->left->var instanceof Variable
+			|| !$ifNode->cond->left->name instanceof Identifier
 			|| !$ifNode->cond->right instanceof ConstFetch
 			|| strcasecmp($ifNode->cond->right->name->name, 'null') !== 0
 		) {
 			return [];
 		}
 
 		$ifThenNode = $ifNode->stmts[0]->expr;
-
 		if (!$ifThenNode instanceof Assign || !$ifThenNode->var instanceof PropertyFetch) {
 			return [];
 		}
 
-		if (get_class($returnNode->expr) !== get_class($ifNode->cond->left)
-			|| get_class($returnNode->expr->var) !== get_class($ifNode->cond->left->var)
-			|| !$returnNode->expr->name instanceof Identifier
-			|| !$ifNode->cond->left->name instanceof Identifier
+		if ($returnNode->expr->var->name !== $ifNode->cond->left->var->name
 			|| $returnNode->expr->name->name !== $ifNode->cond->left->name->name
 		) {
 			return [];