Support method calls / static calls

Author: staabm

src/Analyser/NodeScopeResolver.php

@@ -2851,6 +2851,7 @@ static function (): void {
 
 			if ($parametersAcceptor !== null) {
 				$expr = ArgumentsNormalizer::reorderMethodArguments($parametersAcceptor, $expr) ?? $expr;
+				$isAlwaysTerminating = $parametersAcceptor->getReturnType() instanceof NeverType;
 			}
 
 			$result = $this->processArgs(
@@ -3037,6 +3038,7 @@ static function (): void {
 
 			if ($parametersAcceptor !== null) {
 				$expr = ArgumentsNormalizer::reorderStaticCallArguments($parametersAcceptor, $expr) ?? $expr;
+				$isAlwaysTerminating = $parametersAcceptor->getReturnType() instanceof NeverType;
 			}
 			$result = $this->processArgs($stmt, $methodReflection, null, $parametersAcceptor, $expr, $scope, $nodeCallback, $context, $closureBindScope ?? null);
 			$scope = $result->getScope();

tests/PHPStan/Rules/DeadCode/UnreachableStatementRuleTest.php

@@ -262,4 +262,19 @@ public function testBug13232b(): void
 		]);
 	}
 
+	public function testBug13232c(): void
+	{
+		$this->treatPhpDocTypesAsCertain = false;
+		$this->analyse([__DIR__ . '/data/bug-13232c.php'], [
+			[
+				'Unreachable statement - code above always terminates.',
+				12,
+			],
+			[
+				'Unreachable statement - code above always terminates.',
+				20,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/DeadCode/data/bug-13232c.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace Bug13232c;
+
+final class HelloWorld
+{
+	public function sayHello(): void
+	{
+		echo 'Hello, ' . $this->mightReturnNever()
+			. ' no way';
+
+		echo 'this will never happen';
+	}
+
+	static public function sayStaticHello(): void
+	{
+		echo 'Hello, ' . self::staticMightReturnNever()
+			. ' no way';
+
+		echo 'this will never happen';
+	}
+
+	function mightReturnNever(): never
+
+	{
+		exit();
+	}
+
+	static function staticMightReturnNever(): never
+	{
+		exit();
+	}
+
+}