remove redundant check for object being a constant string

Author: liamduckett

phpstan-baseline.neon

@@ -1647,12 +1647,6 @@ parameters:
 			count: 1
 			path: src/Type/Php/NumberFormatFunctionDynamicReturnTypeExtension.php
 
-		-
-			message: '#^Doing instanceof PHPStan\\Type\\Constant\\ConstantStringType is error\-prone and deprecated\. Use Type\:\:getConstantStrings\(\) instead\.$#'
-			identifier: phpstanApi.instanceofType
-			count: 1
-			path: src/Type/Php/PropertyExistsTypeSpecifyingExtension.php
-
 		-
 			message: '#^Doing instanceof PHPStan\\Type\\Constant\\ConstantStringType is error\-prone and deprecated\. Use Type\:\:getConstantStrings\(\) instead\.$#'
 			identifier: phpstanApi.instanceofType

src/Type/Php/PropertyExistsTypeSpecifyingExtension.php

@@ -16,7 +16,6 @@
 use PHPStan\Rules\Properties\PropertyReflectionFinder;
 use PHPStan\Type\Accessory\HasPropertyType;
 use PHPStan\Type\Constant\ConstantBooleanType;
-use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\FunctionTypeSpecifyingExtension;
 use PHPStan\Type\IntersectionType;
 use PHPStan\Type\ObjectWithoutClassType;
@@ -72,23 +71,22 @@ public function specifyTypes(
 		}
 
 		$objectType = $scope->getType($node->getArgs()[0]->value);
-		if ($objectType instanceof ConstantStringType) {
+
+		if (!$objectType->isObject()->yes()) {
 			return new SpecifiedTypes([], []);
-		} elseif ($objectType->isObject()->yes()) {
-			$propertyNodes = [];
-
-			foreach ($propertyNameTypes as $propertyNameType) {
-				if ($propertyNameType->getValue() === '') {
-					return new SpecifiedTypes([], []);
-				}
-
-				$propertyNodes[] = new PropertyFetch(
-					$node->getArgs()[0]->value,
-					new Identifier($propertyNameType->getValue()),
-				);
+		}
+
+		$propertyNodes = [];
+
+		foreach ($propertyNameTypes as $propertyNameType) {
+			if ($propertyNameType->getValue() === '') {
+				return new SpecifiedTypes([], []);
 			}
-		} else {
-			return new SpecifiedTypes([], []);
+
+			$propertyNodes[] = new PropertyFetch(
+				$node->getArgs()[0]->value,
+				new Identifier($propertyNameType->getValue()),
+			);
 		}
 
 		foreach ($propertyNodes as $propertyNode) {