use PHP_VERSION_ID instead

Girgias · Girgias · commit 44d39ff31cdc · 2024-12-14T22:19:35.000Z
diff --git a/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php b/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php
@@ -905,8 +905,8 @@ public function testInternalClassesWithOverloadedOffsetAccess(): void
 
 	public function testInternalClassesWithOverloadedOffsetAccess84(): void
 	{
-		if (version_compare(PHP_VERSION, '8.4.0', '<')) {
-			$this->markTestSkipped('Test requires PHP version 8.4.');
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.1.');
 		}
 		$this->analyse([__DIR__ . '/data/internal-classes-overload-offset-access-php84.php'], []);
 	}
@@ -918,8 +918,8 @@ public function testInternalClassesWithOverloadedOffsetAccessInvalid(): void
 
 	public function testInternalClassesWithOverloadedOffsetAccessInvalid84(): void
 	{
-		if (version_compare(PHP_VERSION, '8.4.0', '<')) {
-			$this->markTestSkipped('Test requires PHP version 8.4.');
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.1.');
 		}
 		$this->analyse([__DIR__ . '/data/internal-classes-overload-offset-access-invalid-php84.php'], []);
 	}

Original file line number	Diff line number	Diff line change
`@@ -905,8 +905,8 @@ public function testInternalClassesWithOverloadedOffsetAccess(): void`
`905`	`905`
`906`	`906`	`public function testInternalClassesWithOverloadedOffsetAccess84(): void`
`907`	`907`	`{`
`908`		`- if (version_compare(PHP_VERSION, '8.4.0', '<')) {`
`909`		`- $this->markTestSkipped('Test requires PHP version 8.4.');`
	`908`	`+ if (PHP_VERSION_ID < 80400) {`
	`909`	`+ $this->markTestSkipped('Test requires PHP 8.1.');`
`910`	`910`	`}`
`911`	`911`	`$this->analyse([__DIR__ . '/data/internal-classes-overload-offset-access-php84.php'], []);`
`912`	`912`	`}`
`@@ -918,8 +918,8 @@ public function testInternalClassesWithOverloadedOffsetAccessInvalid(): void`
`918`	`918`
`919`	`919`	`public function testInternalClassesWithOverloadedOffsetAccessInvalid84(): void`
`920`	`920`	`{`
`921`		`- if (version_compare(PHP_VERSION, '8.4.0', '<')) {`
`922`		`- $this->markTestSkipped('Test requires PHP version 8.4.');`
	`921`	`+ if (PHP_VERSION_ID < 80400) {`
	`922`	`+ $this->markTestSkipped('Test requires PHP 8.1.');`
`923`	`923`	`}`
`924`	`924`	`$this->analyse([__DIR__ . '/data/internal-classes-overload-offset-access-invalid-php84.php'], []);`
`925`	`925`	`}`