ClassNameUsageLocationCreateIdentifierDynamicReturnTypeExtension - limit possible identifiers based on $location->value type

Author: ondrejmirtes

src/Type/PHPStan/ClassNameUsageLocationCreateIdentifierDynamicReturnTypeExtension.php

@@ -3,6 +3,7 @@
 namespace PHPStan\Type\PHPStan;
 
 use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\PropertyFetch;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Rules\ClassNameUsageLocation;
@@ -41,7 +42,11 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method
 
 		$reflection = new ReflectionClass(ClassNameUsageLocation::class);
 		$identifiers = [];
+		$locationValueType = $scope->getType(new PropertyFetch($methodCall->var, 'value'));
 		foreach ($reflection->getConstants() as $constant) {
+			if (!$locationValueType->isSuperTypeOf($scope->getTypeFromValue($constant))->yes()) {
+				continue;
+			}
 			$location = ClassNameUsageLocation::from($constant);
 			foreach ($secondPartValues as $secondPart) {
 				$identifiers[] = $location->createIdentifier($secondPart->getValue());

tests/PHPStan/Analyser/nsrt/class-name-usage-location.php

@@ -7,4 +7,8 @@
 
 function (ClassNameUsageLocation $location): void {
 	assertType("'assert.test'|'attribute.test'|'catch.test'|'class.extendsTest'|'class.implementsTest'|'classConstant.test'|'enum.implementsTest'|'generics.testBound'|'generics.testDefault'|'instanceof.test'|'interface.extendsTest'|'methodTag.test'|'mixin.test'|'new.test'|'parameter.test'|'property.test'|'propertyTag.test'|'requireExtends.test'|'requireImplements.test'|'return.test'|'selfOut.test'|'staticMethod.test'|'staticProperty.test'|'traitUse.test'|'typeAlias.test'|'varTag.test'", $location->createIdentifier('test'));
+
+	if ($location->value === ClassNameUsageLocation::INSTANTIATION || $location->value === ClassNameUsageLocation::PROPERTY_TYPE) {
+		assertType("'new.test'|'property.test'", $location->createIdentifier('test'));
+	}
 };