Add tests

Author: xPaw

src/Reflection/ParametersAcceptorSelector.php

@@ -936,11 +936,13 @@ private static function getCurlOptValueType(int $curlOpt): ?Type
 		];
 		foreach ($nullableStringConstants as $constName) {
 			if (defined($constName) && constant($constName) === $curlOpt) {
-				return TypeCombinator::intersect(
+				return new UnionType([
 					new NullType(),
-					new StringType(),
-					new AccessoryNonEmptyStringType(),
-				);
+					TypeCombinator::intersect(
+						new StringType(),
+						new AccessoryNonEmptyStringType(),
+					),
+				]);
 			}
 		}
 

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -1314,33 +1314,45 @@ public function testCurlSetOpt(): void
 				'Parameter #3 $value of function curl_setopt expects array<int, string>, int given.',
 				17,
 			],
+			[
+				'Parameter #3 $value of function curl_setopt expects non-empty-string, null given.',
+				18,
+			],
 			[
 				'Parameter #3 $value of function curl_setopt expects bool, int given.',
-				19,
+				20,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects bool, string given.',
-				20,
+				21,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects int, string given.',
-				22,
+				23,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects array, string given.',
-				24,
+				25,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects resource, string given.',
-				26,
+				27,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects array|string, int given.',
-				28,
+				29,
+			],
+			[
+				'Parameter #3 $value of function curl_setopt expects non-empty-string, \'\' given.',
+				31,
+			],
+			[
+				'Parameter #3 $value of function curl_setopt expects non-empty-string|null, \'\' given.',
+				32,
 			],
 			[
 				'Parameter #3 $value of function curl_setopt expects array<int, string>, array<string, string> given.',
-				67,
+				73,
 			],
 		]);
 	}

tests/PHPStan/Rules/Functions/data/curl_setopt.php

@@ -15,6 +15,7 @@ public function errors(int $i, string $s) {
 		// expecting string
 		curl_setopt($curl, CURLOPT_URL, $i);
 		curl_setopt($curl, CURLOPT_HTTPHEADER, $i);
+		curl_setopt($curl, CURLOPT_ABSTRACT_UNIX_SOCKET, null);
 		// expecting bool
 		curl_setopt($curl, CURLOPT_AUTOREFERER, $i);
 		curl_setopt($curl, CURLOPT_RETURNTRANSFER, $s);
@@ -26,6 +27,9 @@ public function errors(int $i, string $s) {
 		curl_setopt($curl, CURLOPT_FILE, $s);
 		// expecting string or array
 		curl_setopt($curl, CURLOPT_POSTFIELDS, $i);
+		// expecting non empty string
+		curl_setopt($curl, CURLOPT_URL, '');
+		curl_setopt($curl, CURLOPT_CUSTOMREQUEST, '');
 	}
 
 	/**
@@ -41,6 +45,8 @@ public function allGood(string $url, array $header) {
 		curl_setopt($curl, CURLOPT_AUTOREFERER, true);
 		curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
 		curl_setopt($curl, CURLOPT_TIMEOUT, 10);
+		curl_setopt($curl, CURLOPT_CUSTOMREQUEST, 'POST');
+		curl_setopt($curl, CURLOPT_CUSTOMREQUEST, null);
 
 		$fp = fopen("example_homepage.txt", "w");
 		if ($fp === false) {