POC

Author: VincentLanglet

src/Type/Accessory/AccessoryLowercaseStringType.php

@@ -110,7 +110,9 @@ public function isSubTypeOfWithReason(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSuperTypeOfWithReason($this);
 		}
 
-		return (new IsSuperTypeOfResult($otherType->isLowercaseString(), []))
+		return (new IsSuperTypeOfResult($otherType->isLowercaseString(), [
+			sprintf("%s is not lowercase.", $otherType->describe(VerbosityLevel::value())),
+		]))
 			->and($otherType instanceof self ? IsSuperTypeOfResult::createYes() : IsSuperTypeOfResult::createMaybe());
 	}
 

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php

@@ -1109,4 +1109,19 @@ public function testBug3979(): void
 		$this->analyse([__DIR__ . '/data/bug-3979.php'], []);
 	}
 
+	public function testBug11799(): void
+	{
+		$this->checkAlwaysTrueCheckTypeFunctionCall = true;
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-11799.php'], [
+			[
+				"Call to function in_array() with arguments string, array{'publishDate', 'approvedAt', 'allowedValues'} and true will always evaluate to false.",
+				11,
+				"• 'publishDate' is not lowercase.
+• 'approvedAt' is not lowercase.
+• 'allowedValues' is not lowercase."
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-11799.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types = 1);
+
+namespace Bug11799;
+
+function getSomeInput(): string { return random_bytes(100); }
+
+function getSortBy(): string
+{
+	$sortBy = mb_strtolower(getSomeInput());
+
+	if (! in_array($sortBy, ['publishDate', 'approvedAt', 'allowedValues'], true)) {
+		// Do something
+	}
+
+	return $sortBy;
+}