Replace unnecessary property

Author: zonuexe

tests/PHPStan/Rules/Classes/ClassConstantRuleTest.php

@@ -21,8 +21,6 @@ class ClassConstantRuleTest extends RuleTestCase
 
 	private int $phpVersion;
 
-	private bool $checkNonStringableDynamicAccess;
-
 	protected function getRule(): Rule
 	{
 		$reflectionProvider = self::createReflectionProvider();
@@ -36,14 +34,13 @@ protected function getRule(): Rule
 				self::getContainer(),
 			),
 			new PhpVersion($this->phpVersion),
-			$this->checkNonStringableDynamicAccess,
+			true,
 		);
 	}
 
 	public function testClassConstant(): void
 	{
 		$this->phpVersion = PHP_VERSION_ID;
-		$this->checkNonStringableDynamicAccess = true;
 		$this->analyse(
 			[
 				__DIR__ . '/data/class-constant.php',
@@ -107,7 +104,6 @@ public function testClassConstant(): void
 	public function testClassConstantVisibility(): void
 	{
 		$this->phpVersion = PHP_VERSION_ID;
-		$this->checkNonStringableDynamicAccess = true;
 		$this->analyse([__DIR__ . '/data/class-constant-visibility.php'], [
 			[
 				'Access to private constant PRIVATE_BAR of class ClassConstantVisibility\Bar.',
@@ -177,7 +173,6 @@ public function testClassConstantVisibility(): void
 	public function testClassExists(): void
 	{
 		$this->phpVersion = PHP_VERSION_ID;
-		$this->checkNonStringableDynamicAccess = true;
 		$this->analyse([__DIR__ . '/data/class-exists.php'], [
 			[
 				'Class UnknownClass\Bar not found.',
@@ -252,14 +247,12 @@ public static function dataClassConstantOnExpression(): array
 	public function testClassConstantOnExpression(int $phpVersion, array $errors): void
 	{
 		$this->phpVersion = $phpVersion;
-		$this->checkNonStringableDynamicAccess = true;
 		$this->analyse([__DIR__ . '/data/class-constant-on-expr.php'], $errors);
 	}
 
 	public function testAttributes(): void
 	{
 		$this->phpVersion = PHP_VERSION_ID;
-		$this->checkNonStringableDynamicAccess = true;
 		$this->analyse([__DIR__ . '/data/class-constant-attribute.php'], [
 			[
 				'Access to undefined constant ClassConstantAttribute\Foo::BAR.',
@@ -296,21 +289,18 @@ public function testAttributes(): void
 	public function testRuleWithNullsafeVariant(): void
 	{
 		$this->phpVersion = PHP_VERSION_ID;
-		$this->checkNonStringableDynamicAccess = true;
 		$this->analyse([__DIR__ . '/data/class-constant-nullsafe.php'], []);
 	}
 
 	public function testBug7675(): void
 	{
 		$this->phpVersion = PHP_VERSION_ID;
-		$this->checkNonStringableDynamicAccess = true;
 		$this->analyse([__DIR__ . '/data/bug-7675.php'], []);
 	}
 
 	public function testBug8034(): void
 	{
 		$this->phpVersion = PHP_VERSION_ID;
-		$this->checkNonStringableDynamicAccess = true;
 		$this->analyse([__DIR__ . '/data/bug-8034.php'], [
 			[
 				'Access to undefined constant static(Bug8034\HelloWorld)::FIELDS.',
@@ -322,7 +312,6 @@ public function testBug8034(): void
 	public function testClassConstFetchDefined(): void
 	{
 		$this->phpVersion = PHP_VERSION_ID;
-		$this->checkNonStringableDynamicAccess = true;
 		$this->analyse([__DIR__ . '/data/class-const-fetch-defined.php'], [
 			[
 				'Access to undefined constant ClassConstFetchDefined\Foo::TEST.',
@@ -424,7 +413,6 @@ public function testPhpstanInternalClass(): void
 		$tip = 'This is most likely unintentional. Did you mean to type \AClass?';
 
 		$this->phpVersion = PHP_VERSION_ID;
-		$this->checkNonStringableDynamicAccess = true;
 		$this->analyse([__DIR__ . '/data/phpstan-internal-class.php'], [
 			[
 				'Referencing prefixed PHPStan class: _PHPStan_156ee64ba\AClass.',
@@ -438,7 +426,6 @@ public function testPhpstanInternalClass(): void
 	public function testClassConstantAccessedOnTrait(): void
 	{
 		$this->phpVersion = PHP_VERSION_ID;
-		$this->checkNonStringableDynamicAccess = true;
 		$this->analyse([__DIR__ . '/data/class-constant-accessed-on-trait.php'], [
 			[
 				'Cannot access constant TEST on trait ClassConstantAccessedOnTrait\Foo.',
@@ -451,7 +438,6 @@ public function testClassConstantAccessedOnTrait(): void
 	public function testDynamicAccess(): void
 	{
 		$this->phpVersion = PHP_VERSION_ID;
-		$this->checkNonStringableDynamicAccess = true;
 
 		$this->analyse([__DIR__ . '/data/dynamic-constant-access.php'], [
 			[
@@ -504,7 +490,6 @@ public function testStringableDynamicAccess(): void
 		}
 
 		$this->phpVersion = PHP_VERSION_ID;
-		$this->checkNonStringableDynamicAccess = true;
 
 		$this->analyse([__DIR__ . '/data/dynamic-constant-stringable-access.php'], [
 			[