Fix MethodExistsTypeSpecifyingExtension for union types

Author: staabm

src/Type/Php/MethodExistsTypeSpecifyingExtension.php

@@ -14,7 +14,6 @@
 use PHPStan\Type\Accessory\HasMethodType;
 use PHPStan\Type\ClassStringType;
 use PHPStan\Type\Constant\ConstantBooleanType;
-use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\FunctionTypeSpecifyingExtension;
 use PHPStan\Type\IntersectionType;
 use PHPStan\Type\ObjectWithoutClassType;
@@ -50,8 +49,8 @@ public function specifyTypes(
 		TypeSpecifierContext $context,
 	): SpecifiedTypes
 	{
-		$methodNameType = $scope->getType($node->getArgs()[1]->value);
-		if (!$methodNameType instanceof ConstantStringType) {
+		$methodNameTypes = $scope->getType($node->getArgs()[1]->value)->getConstantStrings();
+		if ($methodNameTypes === []) {
 			return $this->typeSpecifier->create(
 				new FuncCall(new FullyQualified('method_exists'), $node->getRawArgs()),
 				new ConstantBooleanType(true),
@@ -60,14 +59,19 @@ public function specifyTypes(
 			);
 		}
 
+		$hasMethodTypes = [];
+		foreach ($methodNameTypes as $methodNameType) {
+			$hasMethodTypes[] = new HasMethodType($methodNameType->getValue());
+		}
+
 		$objectType = $scope->getType($node->getArgs()[0]->value);
 		if ($objectType->isString()->yes()) {
 			if ($objectType->isClassString()->yes()) {
 				return $this->typeSpecifier->create(
 					$node->getArgs()[0]->value,
 					new IntersectionType([
 						$objectType,
-						new HasMethodType($methodNameType->getValue()),
+						...$hasMethodTypes,
 					]),
 					$context,
 					$scope,
@@ -82,7 +86,7 @@ public function specifyTypes(
 			new UnionType([
 				new IntersectionType([
 					new ObjectWithoutClassType(),
-					new HasMethodType($methodNameType->getValue()),
+					...$hasMethodTypes,
 				]),
 				new ClassStringType(),
 			]),

tests/PHPStan/Analyser/nsrt/bug-13272.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace Bug13272;
+
+use function PHPStan\Testing\assertType;
+
+function foo(object $bar): void
+{
+	foreach (['qux', 'quux'] as $method) {
+		assertType("'quux'|'qux'", $method);
+
+		if (!method_exists($bar, $method)) {
+			throw new \Exception;
+		}
+
+		assertType("'quux'|'qux'", $method);
+		assertType("object&hasMethod(quux)&hasMethod(qux)", $bar);
+	}
+}