Simplify by replacing chained $var === const with in_array()

Author: zonuexe

src/Fixable/PhpPrinterIndentationDetectorVisitor.php

@@ -8,6 +8,7 @@
 use PhpParser\NodeVisitor;
 use PhpParser\NodeVisitorAbstract;
 use function count;
+use function in_array;
 use function is_array;
 use function preg_match;
 use function preg_match_all;
@@ -47,7 +48,7 @@ public function enterNode(Node $node): ?int
 		$text = $this->origTokens->getTokenCode($node->getStartTokenPos(), $firstStmt->getStartTokenPos(), 0);
 
 		$c = preg_match_all('~\n([\\x09\\x20]*)~', $text, $matches, PREG_SET_ORDER);
-		if ($c === 0 || $c === false) {
+		if (in_array($c, [0, false], true)) {
 			return null;
 		}
 

src/Reflection/InitializerExprTypeResolver.php

@@ -864,7 +864,7 @@ public function getDivType(Expr $left, Expr $right, callable $getTypeCallback):
 
 		$rightScalarValues = $rightType->toNumber()->getConstantScalarValues();
 		foreach ($rightScalarValues as $scalarValue) {
-			if ($scalarValue === 0 || $scalarValue === 0.0) {
+			if (in_array($scalarValue, [0, 0.0], true)) {
 				return new ErrorType();
 			}
 		}
@@ -938,7 +938,7 @@ public function getModType(Expr $left, Expr $right, callable $getTypeCallback):
 		$rightScalarValues = $rightType->toNumber()->getConstantScalarValues();
 		foreach ($rightScalarValues as $scalarValue) {
 
-			if ($scalarValue === 0 || $scalarValue === 0.0) {
+			if (in_array($scalarValue, [0, 0.0], true)) {
 				return new ErrorType();
 			}
 		}

src/Rules/Keywords/ContinueBreakInLoopRule.php

@@ -10,6 +10,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use function array_reverse;
+use function in_array;
 use function sprintf;
 
 /**
@@ -52,13 +53,13 @@ public function processNode(Node $node, Scope $scope): array
 						->build(),
 				];
 			}
-			if (
-				$parentStmtType === Stmt\For_::class
-				|| $parentStmtType === Stmt\Foreach_::class
-				|| $parentStmtType === Stmt\Do_::class
-				|| $parentStmtType === Stmt\While_::class
-				|| $parentStmtType === Stmt\Switch_::class
-			) {
+			if (in_array($parentStmtType, [
+				Stmt\For_::class,
+				Stmt\Foreach_::class,
+				Stmt\Do_::class,
+				Stmt\While_::class,
+				Stmt\Switch_::class,
+			], true)) {
 				$value--;
 			}
 			if ($value === 0) {

src/Rules/UnusedFunctionParametersCheck.php

@@ -12,6 +12,7 @@
 use function array_combine;
 use function array_map;
 use function array_merge;
+use function in_array;
 use function is_array;
 use function is_string;
 use function sprintf;
@@ -78,7 +79,7 @@ private function getUsedVariables(Scope $scope, $node): array
 		if ($node instanceof Node) {
 			if ($node instanceof Node\Expr\FuncCall && $node->name instanceof Node\Name) {
 				$functionName = $this->reflectionProvider->resolveFunctionName($node->name, $scope);
-				if ($functionName === 'func_get_args' || $functionName === 'get_defined_vars') {
+				if (in_array($functionName, ['func_get_args', 'get_defined_vars'], true)) {
 					return $scope->getDefinedVariables();
 				}
 			}

src/Type/Php/DsMapDynamicMethodThrowTypeExtension.php

@@ -10,6 +10,7 @@
 use PHPStan\Type\Type;
 use PHPStan\Type\VoidType;
 use function count;
+use function in_array;
 
 #[AutowiredService]
 final class DsMapDynamicMethodThrowTypeExtension implements DynamicMethodThrowTypeExtension
@@ -18,7 +19,7 @@ final class DsMapDynamicMethodThrowTypeExtension implements DynamicMethodThrowTy
 	public function isMethodSupported(MethodReflection $methodReflection): bool
 	{
 		return $methodReflection->getDeclaringClass()->getName() === 'Ds\Map'
-			&& ($methodReflection->getName() === 'get' || $methodReflection->getName() === 'remove');
+			&& in_array($methodReflection->getName(), ['get', 'remove'], true);
 	}
 
 	public function getThrowTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): ?Type

src/Type/Php/StrWordCountFunctionDynamicReturnTypeExtension.php

@@ -16,6 +16,7 @@
 use PHPStan\Type\Type;
 use PHPStan\Type\UnionType;
 use function count;
+use function in_array;
 
 #[AutowiredService]
 final class StrWordCountFunctionDynamicReturnTypeExtension implements DynamicFunctionReturnTypeExtension
@@ -35,14 +36,14 @@ public function getTypeFromFunctionCall(
 		$argsCount = count($functionCall->getArgs());
 		if ($argsCount === 1) {
 			return new IntegerType();
-		} elseif ($argsCount === 2 || $argsCount === 3) {
+		} elseif (in_array($argsCount, [2, 3], true)) {
 			$formatType = $scope->getType($functionCall->getArgs()[1]->value);
 			if ($formatType instanceof ConstantIntegerType) {
 				$val = $formatType->getValue();
 				if ($val === 0) {
 					// return word count
 					return new IntegerType();
-				} elseif ($val === 1 || $val === 2) {
+				} elseif (in_array($val, [1, 2], true)) {
 					// return [word] or [offset => word]
 					return new ArrayType(new IntegerType(), new StringType());
 				}

src/Type/Regex/RegexGroupParser.php

@@ -711,7 +711,7 @@ private function getLiteralValue(TreeNode $node, ?array &$onlyLiterals, bool $ap
 			}
 		}
 
-		if ($token === 'anchor' || $token === 'match_point_reset') {
+		if (in_array($token, ['anchor', 'match_point_reset'], true)) {
 			return '';
 		}