test property hooks

Author: staabm

src/Analyser/MutatingScope.php

@@ -3350,7 +3350,7 @@ public function enterFunction(
 
 	private function enterFunctionLike(
 		PhpFunctionFromParserNodeReflection $functionReflection,
-		bool                                $preserveConstructorScope,
+		bool $preserveConstructorScope,
 	): self
 	{
 		$parametersByName = [];

src/Analyser/NodeScopeResolver.php

@@ -930,9 +930,16 @@ private function processStmtNode(
 			$classStatementsGatherer = new ClassStatementsGatherer($classReflection, $nodeCallback);
 			$this->processAttributeGroups($stmt, $stmt->attrGroups, $classScope, $classStatementsGatherer);
 
-			// analyze static methods first, constructor next and instance methods last so we can carry over the scope
+			// analyze static methods first; constructor next; instance methods and property hooks last so we can carry over the scope
 			$classLikeStatements = $stmt->stmts;
 			usort($classLikeStatements, static function ($a, $b) {
+				if ($a instanceof Node\Stmt\Property) {
+					return 1;
+				}
+				if ($b instanceof Node\Stmt\Property) {
+					return -1;
+				}
+
 				if (!$a instanceof Node\Stmt\ClassMethod || !$b instanceof Node\Stmt\ClassMethod) {
 					return 0;
 				}

tests/PHPStan/Analyser/nsrt/remember-readonly-constructor-narrowed-hooks.php

@@ -0,0 +1,35 @@
+<?php // lint >= 8.4
+
+namespace RememberReadOnlyConstructorInPropertyHookBodies;
+
+use function PHPStan\Testing\assertType;
+
+class User
+{
+	public string $name {
+		get {
+			assertType('1|2', $this->type);
+			return $this->name ;
+		}
+		set {
+			if (strlen($value) === 0) {
+				throw new ValueError("Name must be non-empty");
+			}
+			assertType('1|2', $this->type);
+			$this->name = $value;
+		}
+	}
+
+	private readonly int $type;
+
+	public function __construct(
+		string $name
+	) {
+		$this->name = $name;
+		if (rand(0,1)) {
+			$this->type = 1;
+		} else {
+			$this->type = 2;
+		}
+	}
+}