Test how #[Override] behaves with constructors

Author: ondrejmirtes

tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php

@@ -770,6 +770,10 @@ public function testOverrideAttribute(): void
 				'Method OverrideAttribute\Bar::test2() has #[\Override] attribute but does not override any method.',
 				24,
 			],
+			[
+				'Method OverrideAttribute\ChildOfParentWithConstructor::__construct() has #[\Override] attribute but does not override any method.',
+				42,
+			],
 		]);
 	}
 
@@ -783,6 +787,10 @@ public function dataCheckMissingOverrideAttribute(): iterable
 				'Method CheckMissingOverrideAttr\Bar::doFoo() overrides method CheckMissingOverrideAttr\Foo::doFoo() but is missing the #[\Override] attribute.',
 				18,
 			],
+			[
+				'Method CheckMissingOverrideAttr\ChildOfParentWithAbstractConstructor::__construct() overrides method CheckMissingOverrideAttr\ParentWithAbstractConstructor::__construct() but is missing the #[\Override] attribute.',
+				49,
+			],
 		]];
 	}
 

tests/PHPStan/Rules/Methods/data/check-missing-override-attr.php

@@ -21,3 +21,31 @@ public function doFoo(): void
 	}
 
 }
+
+class ParentWithConstructor
+{
+
+	public function __construct() {}
+
+}
+
+
+class ChildOfParentWithConstructor extends ParentWithConstructor {
+
+	public function __construct() {}
+
+}
+
+abstract class ParentWithAbstractConstructor
+{
+
+	abstract public function __construct();
+
+}
+
+
+class ChildOfParentWithAbstractConstructor extends ParentWithAbstractConstructor {
+
+	public function __construct() {}
+
+}

tests/PHPStan/Rules/Methods/data/override-attribute.php

@@ -28,3 +28,33 @@ public function test2(): void
 	}
 
 }
+
+class ParentWithConstructor
+{
+
+	public function __construct() {}
+
+}
+
+
+class ChildOfParentWithConstructor extends ParentWithConstructor {
+
+	#[\Override]
+	public function __construct() {}
+
+}
+
+abstract class ParentWithAbstractConstructor
+{
+
+	abstract public function __construct();
+
+}
+
+
+class ChildOfParentWithAbstractConstructor extends ParentWithAbstractConstructor {
+
+	#[\Override]
+	public function __construct() {}
+
+}