keep || and () exceptions for ignore rules validations

Author: mvorisek

src/Command/IgnoredRegexValidator.php

@@ -13,7 +13,6 @@
 use PHPStan\Type\VerbosityLevel;
 use function count;
 use function str_contains;
-use function str_starts_with;
 use function strrpos;
 use function substr;
 
@@ -34,19 +33,17 @@ public function validate(string $regex): IgnoredRegexValidatorResult
 		try {
 			/** @var TreeNode $ast */
 			$ast = $this->parser->parse($regex);
-		} catch (Exception $e) {
-			if (str_starts_with($e->getMessage(), 'Unexpected token "|" (alternation) at line 1')) {
-				return new IgnoredRegexValidatorResult([], false, true, '||', '\|\|');
-			}
-			if (
-				str_contains($regex, '()')
-				&& str_starts_with($e->getMessage(), 'Unexpected token ")" (_capturing) at line 1')
-			) {
-				return new IgnoredRegexValidatorResult([], false, true, '()', '\(\)');
-			}
+		} catch (Exception) {
 			return new IgnoredRegexValidatorResult([], false, false);
 		}
 
+		if (str_contains($regex, '||')) {
+			return new IgnoredRegexValidatorResult([], false, true, '||', '\|\|');
+		}
+		if (str_contains($regex, '()')) {
+			return new IgnoredRegexValidatorResult([], false, true, '()', '\(\)');
+		}
+
 		return new IgnoredRegexValidatorResult(
 			$this->getIgnoredTypes($ast),
 			$this->hasAnchorsInTheMiddle($ast),

tests/PHPStan/Command/IgnoredRegexValidatorTest.php

@@ -104,15 +104,13 @@ public function dataValidate(): array
 				'~Result of || is always true.~',
 				[],
 				false,
-				false,
+				true,
 			],
 			[
 				'#Method PragmaRX\Notified\Data\Repositories\Notified::firstOrCreateByEvent() should return PragmaRX\Notified\Data\Models\Notified but returns Illuminate\Database\Eloquent\Model|null#',
-				[
-					'null' => 'null',
-				],
-				false,
+				[],
 				false,
+				true,
 			],
 		];
 	}