Fix InvalidKeyInArrayDimFetchRule

Author: VincentLanglet

src/Rules/Arrays/InvalidKeyInArrayDimFetchRule.php

@@ -10,7 +10,6 @@
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Type\ErrorType;
-use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
 use PHPStan\Type\VerbosityLevel;
 use function sprintf;
@@ -41,22 +40,27 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$dimensionType = $scope->getType($node->dim);
-		if ($dimensionType instanceof MixedType) {
-			return [];
-		}
-
 		$varType = $this->ruleLevelHelper->findTypeToCheck(
 			$scope,
 			$node->var,
 			'',
-			static fn (Type $varType): bool => $varType->isArray()->no() || AllowedArrayKeysTypes::getType()->isSuperTypeOf($dimensionType)->yes(),
+			static fn (Type $varType): bool => $varType->isArray()->no(),
 		)->getType();
 
 		if ($varType instanceof ErrorType || $varType->isArray()->no()) {
 			return [];
 		}
 
+		$dimensionType = $this->ruleLevelHelper->findTypeToCheck(
+			$scope,
+			$node->dim,
+			'',
+			static fn (Type $dimType): bool => AllowedArrayKeysTypes::getType()->isSuperTypeOf($dimType)->yes(),
+		)->getType();
+		if ($dimensionType instanceof ErrorType) {
+			return [];
+		}
+
 		$isSuperType = AllowedArrayKeysTypes::getType()->isSuperTypeOf($dimensionType);
 		if ($isSuperType->yes() || ($isSuperType->maybe() && !$this->reportMaybes)) {
 			return [];

tests/PHPStan/Levels/data/arrayOffsetAccess-10-missing.json

@@ -0,0 +1,7 @@
+[
+    {
+        "message": "Invalid array key type object.",
+        "line": 20,
+        "ignorable": true
+    }
+]

tests/PHPStan/Levels/data/arrayOffsetAccess-10.json

@@ -0,0 +1,7 @@
+[
+    {
+        "message": "Possibly invalid array key type mixed.",
+        "line": 22,
+        "ignorable": true
+    }
+]

tests/PHPStan/Levels/data/arrayOffsetAccess-7.json

@@ -5,7 +5,7 @@
         "ignorable": true
     },
     {
-        "message": "Possibly invalid array key type object|null.",
+        "message": "Invalid array key type object.",
         "line": 20,
         "ignorable": true
     }

tests/PHPStan/Levels/data/arrayOffsetAccess-8-missing.json

@@ -0,0 +1,7 @@
+[
+    {
+        "message": "Invalid array key type object.",
+        "line": 20,
+        "ignorable": true
+    }
+]

tests/PHPStan/Levels/data/arrayOffsetAccess-8.json

@@ -0,0 +1,7 @@
+[
+    {
+        "message": "Possibly invalid array key type object|null.",
+        "line": 20,
+        "ignorable": true
+    }
+]

tests/PHPStan/Levels/data/arrayOffsetAccess-9-missing.json

@@ -0,0 +1,7 @@
+[
+    {
+        "message": "Invalid array key type object.",
+        "line": 20,
+        "ignorable": true
+    }
+]

tests/PHPStan/Levels/data/arrayOffsetAccess-9.json

@@ -0,0 +1,7 @@
+[
+    {
+        "message": "Possibly invalid array key type mixed.",
+        "line": 21,
+        "ignorable": true
+    }
+]

tests/PHPStan/Levels/data/arrayOffsetAccess.php

@@ -3,15 +3,15 @@
 namespace Levels\ArrayOffsetAccess;
 
 class Foo {
-	/** @return void */
-	public function test(
-		array $a,
-		int|null $intOrNull,
-		object|int $objectOrInt,
-		object|null $objectOrNull,
-		mixed $explicitlyMixed,
-		$implicitlyMixed,
-	) {
+	/**
+	 * @param int|null $intOrNull
+	 * @param object|int $objectOrInt
+	 * @param object|null $objectOrNull
+	 * @param mixed $explicitlyMixed
+	 * @return void
+	 */
+	public function test(array $a, $intOrNull, $objectOrInt, $objectOrNull, $explicitlyMixed, $implicitlyMixed)
+	{
 		$a[42];
 		$a[null];
 		$a[new \DateTimeImmutable()];