Enum-case comparison: cheap checks first

staabm · ondrejmirtes · commit 6c85acc5c209 · 2024-05-11T09:32:52.000+02:00
diff --git a/src/Type/Enum/EnumCaseObjectType.php b/src/Type/Enum/EnumCaseObjectType.php
@@ -53,8 +53,8 @@ public function equals(Type $type): bool
 			return false;
 		}
 
-		return $this->getClassName() === $type->getClassName()
-			&& $this->enumCaseName === $type->enumCaseName;
+		return $this->enumCaseName === $type->enumCaseName &&
+			$this->getClassName() === $type->getClassName();
 	}
 
 	public function accepts(Type $type, bool $strictTypes): TrinaryLogic
@@ -71,8 +71,7 @@ public function isSuperTypeOf(Type $type): TrinaryLogic
 	{
 		if ($type instanceof self) {
 			return TrinaryLogic::createFromBoolean(
-				$this->getClassName() === $type->getClassName()
-				&& $this->enumCaseName === $type->enumCaseName,
+				$this->enumCaseName === $type->enumCaseName && $this->getClassName() === $type->getClassName(),
 			);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,8 @@ public function equals(Type $type): bool`
`53`	`53`	`return false;`
`54`	`54`	`}`
`55`	`55`
`56`		`- return $this->getClassName() === $type->getClassName()`
`57`		`- && $this->enumCaseName === $type->enumCaseName;`
	`56`	`+ return $this->enumCaseName === $type->enumCaseName &&`
	`57`	`+ $this->getClassName() === $type->getClassName();`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`public function accepts(Type $type, bool $strictTypes): TrinaryLogic`
`@@ -71,8 +71,7 @@ public function isSuperTypeOf(Type $type): TrinaryLogic`
`71`	`71`	`{`
`72`	`72`	`if ($type instanceof self) {`
`73`	`73`	`return TrinaryLogic::createFromBoolean(`
`74`		`- $this->getClassName() === $type->getClassName()`
`75`		`- && $this->enumCaseName === $type->enumCaseName,`
	`74`	`+ $this->enumCaseName === $type->enumCaseName && $this->getClassName() === $type->getClassName(),`
`76`	`75`	`);`
`77`	`76`	`}`
`78`	`77`