PHP 7.4 compatibility

VincentLanglet · VincentLanglet · commit 6d9a964dce32 · 2025-05-18T17:29:26.000+02:00
diff --git a/src/Rules/InternalTag/RestrictedInternalUsageHelper.php b/src/Rules/InternalTag/RestrictedInternalUsageHelper.php
@@ -14,9 +14,12 @@ public function shouldBeReported(Scope $scope, string $name): bool
 	{
 		$currentNamespace = $scope->getNamespace();
 		if ($currentNamespace === null) {
-			$currentClass = $scope->getClassReflection()?->getName();
+			$classReflection = $scope->getClassReflection();
+			if (null === $classReflection) {
+				return true;
+			}
 
-			return $currentClass !== $name;
+			return $classReflection->getName() !== $name;
 		}
 
 		$currentNamespace = explode('\\', $currentNamespace)[0];

Original file line number	Diff line number	Diff line change
`@@ -14,9 +14,12 @@ public function shouldBeReported(Scope $scope, string $name): bool`
`14`	`14`	`{`
`15`	`15`	`$currentNamespace = $scope->getNamespace();`
`16`	`16`	`if ($currentNamespace === null) {`
`17`		`- $currentClass = $scope->getClassReflection()?->getName();`
	`17`	`+ $classReflection = $scope->getClassReflection();`
	`18`	`+ if (null === $classReflection) {`
	`19`	`+ return true;`
	`20`	`+ }`
`18`	`21`
`19`		`- return $currentClass !== $name;`
	`22`	`+ return $classReflection->getName() !== $name;`
`20`	`23`	`}`
`21`	`24`
`22`	`25`	`$currentNamespace = explode('\\', $currentNamespace)[0];`