Fix tests

janedbal · janedbal · commit 7142ddc0ec51 · 2025-05-12T13:10:39.000+02:00
diff --git a/tests/PHPStan/Rules/Exceptions/ThrowsVoidFunctionWithExplicitThrowPointRuleTest.php b/tests/PHPStan/Rules/Exceptions/ThrowsVoidFunctionWithExplicitThrowPointRuleTest.php
@@ -4,6 +4,7 @@
 
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
+use ThrowsVoidFunction\DifferentException;
 use ThrowsVoidFunction\MyException;
 
 /**
@@ -38,7 +39,13 @@ public function dataRule(): array
 			],
 			[
 				false,
-				['DifferentException'],
+				[DifferentException::class],
+				[
+					[
+						'Function ThrowsVoidFunction\foo() throws exception ThrowsVoidFunction\MyException but the PHPDoc contains @throws void.',
+						15,
+					],
+				],
 				[
 					[
 						'Function ThrowsVoidFunction\foo() throws exception ThrowsVoidFunction\MyException but the PHPDoc contains @throws void.',
@@ -53,7 +60,7 @@ public function dataRule(): array
 			],
 			[
 				true,
-				['DifferentException'],
+				[DifferentException::class],
 				[
 					[
 						'Function ThrowsVoidFunction\foo() throws exception ThrowsVoidFunction\MyException but the PHPDoc contains @throws void.',
diff --git a/tests/PHPStan/Rules/Exceptions/ThrowsVoidPropertyHookWithExplicitThrowPointRuleTest.php b/tests/PHPStan/Rules/Exceptions/ThrowsVoidPropertyHookWithExplicitThrowPointRuleTest.php
@@ -38,7 +38,7 @@ public function dataRule(): array
 			],
 			[
 				false,
-				['DifferentException'],
+				['ThrowsVoidPropertyHook\\DifferentException'],
 				[
 					[
 						'Get hook for property ThrowsVoidPropertyHook\Foo::$i throws exception ThrowsVoidPropertyHook\MyException but the PHPDoc contains @throws void.',
@@ -57,7 +57,7 @@ public function dataRule(): array
 			],
 			[
 				true,
-				['DifferentException'],
+				['ThrowsVoidPropertyHook\\DifferentException'],
 				[
 					[
 						'Get hook for property ThrowsVoidPropertyHook\Foo::$i throws exception ThrowsVoidPropertyHook\MyException but the PHPDoc contains @throws void.',
diff --git a/tests/PHPStan/Rules/Exceptions/data/throws-void-function.php b/tests/PHPStan/Rules/Exceptions/data/throws-void-function.php
@@ -2,10 +2,10 @@
 
 namespace ThrowsVoidFunction;
 
-class MyException extends \Exception
-{
+class MyException extends \Exception {}
+
+class DifferentException extends \Exception {}
 
-}
 
 /**
  * @throws void
diff --git a/tests/PHPStan/Rules/Exceptions/data/throws-void-property-hook.php b/tests/PHPStan/Rules/Exceptions/data/throws-void-property-hook.php
@@ -2,10 +2,10 @@
 
 namespace ThrowsVoidPropertyHook;
 
-class MyException extends \Exception
-{
+class MyException extends \Exception {}
+
+class DifferentException extends \Exception {}
 
-}
 
 class Foo
 {

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`
`5`	`5`	`use PHPStan\Rules\Rule;`
`6`	`6`	`use PHPStan\Testing\RuleTestCase;`
	`7`	`+use ThrowsVoidFunction\DifferentException;`
`7`	`8`	`use ThrowsVoidFunction\MyException;`
`8`	`9`
`9`	`10`	`/**`
`@@ -38,7 +39,13 @@ public function dataRule(): array`
`38`	`39`	`],`
`39`	`40`	`[`
`40`	`41`	`false,`
`41`		`- ['DifferentException'],`
	`42`	`+ [DifferentException::class],`
	`43`	`+ [`
	`44`	`+ [`
	`45`	`+ 'Function ThrowsVoidFunction\foo() throws exception ThrowsVoidFunction\MyException but the PHPDoc contains @throws void.',`
	`46`	`+ 15,`
	`47`	`+ ],`
	`48`	`+ ],`
`42`	`49`	`[`
`43`	`50`	`[`
`44`	`51`	`'Function ThrowsVoidFunction\foo() throws exception ThrowsVoidFunction\MyException but the PHPDoc contains @throws void.',`
`@@ -53,7 +60,7 @@ public function dataRule(): array`
`53`	`60`	`],`
`54`	`61`	`[`
`55`	`62`	`true,`
`56`		`- ['DifferentException'],`
	`63`	`+ [DifferentException::class],`
`57`	`64`	`[`
`58`	`65`	`[`
`59`	`66`	`'Function ThrowsVoidFunction\foo() throws exception ThrowsVoidFunction\MyException but the PHPDoc contains @throws void.',`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function dataRule(): array`
`38`	`38`	`],`
`39`	`39`	`[`
`40`	`40`	`false,`
`41`		`- ['DifferentException'],`
	`41`	`+ ['ThrowsVoidPropertyHook\\DifferentException'],`
`42`	`42`	`[`
`43`	`43`	`[`
`44`	`44`	`'Get hook for property ThrowsVoidPropertyHook\Foo::$i throws exception ThrowsVoidPropertyHook\MyException but the PHPDoc contains @throws void.',`
`@@ -57,7 +57,7 @@ public function dataRule(): array`
`57`	`57`	`],`
`58`	`58`	`[`
`59`	`59`	`true,`
`60`		`- ['DifferentException'],`
	`60`	`+ ['ThrowsVoidPropertyHook\\DifferentException'],`
`61`	`61`	`[`
`62`	`62`	`[`
`63`	`63`	`'Get hook for property ThrowsVoidPropertyHook\Foo::$i throws exception ThrowsVoidPropertyHook\MyException but the PHPDoc contains @throws void.',`