Fix session_set_cookie_params call with named arguments

Author: ondrejmirtes

src/Analyser/ArgumentsNormalizer.php

@@ -18,6 +18,7 @@
 use function count;
 use function ksort;
 use function max;
+use function sprintf;
 
 /**
  * @api
@@ -276,7 +277,7 @@ public static function reorderArgs(ParametersAcceptor $parametersAcceptor, array
 			$defaultValue = $parameter->getDefaultValue();
 			if ($defaultValue === null) {
 				if (!$parameter->isVariadic()) {
-					throw new ShouldNotHappenException('An optional parameter must have a default value');
+					throw new ShouldNotHappenException(sprintf('An optional parameter $%s must have a default value', $parameter->getName()));
 				}
 				$defaultValue = new ConstantArrayType([], []);
 			}

src/Reflection/SignatureMap/Php8SignatureMapProvider.php

@@ -272,8 +272,8 @@ private function getMergedSignatures(FunctionSignature $nativeSignature, array $
 					$functionParam->getNativeType(),
 					$functionParam->passedByReference(),
 					$functionParam->isVariadic(),
-					$functionParam->getDefaultValue(),
-					$functionParam->getOutType(),
+					$functionParam->getDefaultValue() ?? $nativeParam->getDefaultValue(),
+					$functionParam->getOutType() ?? $nativeParam->getOutType(),
 				);
 			}
 

tests/PHPStan/Analyser/AnalyserIntegrationTest.php

@@ -1138,6 +1138,16 @@ public function testBug8147(): void
 		$this->assertNoErrors($errors);
 	}
 
+	public function testBug12934(): void
+	{
+		if (PHP_VERSION_ID < 80000) {
+			$this->markTestSkipped('Test requires PHP 8.0.');
+		}
+
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-12934.php');
+		$this->assertNoErrors($errors);
+	}
+
 	public function testConditionalExpressionInfiniteLoop(): void
 	{
 		$errors = $this->runAnalyse(__DIR__ . '/data/conditional-expression-infinite-loop.php');

tests/PHPStan/Analyser/data/bug-12934.php

@@ -0,0 +1,9 @@
+<?php // lint >= 8.0
+
+declare(strict_types = 1);
+
+namespace Bug12934;
+
+function(string $path): void {
+	session_set_cookie_params(0, path: $path, secure: true, httponly: true);
+};