NamedArgumentsRule - do not touch by-ref arguments

Author: ondrejmirtes

build/PHPStan/Build/NamedArgumentsRule.php

@@ -125,6 +125,9 @@ private function processArgs(ExtendedParametersAcceptor $acceptor, Scope $scope,
 			if ($parameter->getDefaultValue() === null) {
 				continue;
 			}
+			if (!$parameter->passedByReference()->no()) {
+				continue;
+			}
 			$argValue = $scope->getType($normalizedArg->value);
 			if ($normalizedArg->name !== null) {
 				continue;
@@ -192,6 +195,10 @@ private function processArgs(ExtendedParametersAcceptor $acceptor, Scope $scope,
 						$newArgs[] = $originalArg;
 						continue;
 					}
+					if (!$parameter->passedByReference()->no()) {
+						$newArgs[] = $originalArg;
+						continue;
+					}
 					$argValue = $scope->getType($normalizedArg->value);
 					if ($argValue->equals($parameter->getDefaultValue())) {
 						$skippedOptional = true;

tests/PHPStan/Build/NamedArgumentsRuleTest.php

@@ -37,6 +37,10 @@ public function testRule(): void
 				'You\'re passing a non-default value Exception to parameter $previous but previous arguments are passing default values to their parameters ($message, $code). You can skip them and use named argument for $previous instead.',
 				20,
 			],
+			[
+				'You\'re passing a non-default value 3 to parameter $yetAnother but previous argument is passing default value to its parameter ($another). You can skip it and use named argument for $yetAnother instead.',
+				41,
+			],
 		]);
 	}
 

tests/PHPStan/Build/data/named-arguments.php

@@ -21,3 +21,24 @@ public function doFoo(): void
 	}
 
 }
+
+function (): void {
+	$output = null;
+	exec('exec', $output, $exitCode);
+};
+
+class Bar
+{
+
+	public static function doFoo($a, &$byRef = null, int $another = 1, int $yetAnother = 2): void
+	{
+
+	}
+
+	public function doBar(): void
+	{
+		$byRef = null;
+		self::doFoo('a', $byRef, 1, 3);
+	}
+
+}

tests/PHPStan/Build/data/named-arguments.php.fixed

@@ -21,3 +21,24 @@ class Foo
 	}
 
 }
+
+function (): void {
+	$output = null;
+	exec('exec', $output, $exitCode);
+};
+
+class Bar
+{
+
+	public static function doFoo($a, &$byRef = null, int $another = 1, int $yetAnother = 2): void
+	{
+
+	}
+
+	public function doBar(): void
+	{
+		$byRef = null;
+		self::doFoo('a', $byRef, yetAnother: 3);
+	}
+
+}