regression tests

Author: staabm

tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php

@@ -14,6 +14,7 @@ class TypesAssignedToPropertiesRuleTest extends RuleTestCase
 {
 
 	private bool $checkExplicitMixed = false;
+
 	private bool $checkImplicitMixed = false;
 
 	protected function getRule(): Rule
@@ -796,4 +797,14 @@ public function testBug8825(): void
 		$this->analyse([__DIR__ . '/data/bug-8825.php'], []);
 	}
 
+	public function testBug7844(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-7844.php'], []);
+	}
+
+	public function testBug7844b(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-7844b.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/bug-7844.php

@@ -12,11 +12,8 @@ class C
 
 	public function foo(): void
 	{
-		\PHPStan\dumpType($this->data);
 		if (count($this->data) > 0) {
-			\PHPStan\dumpType($this->data);
 			$this->val = array_shift($this->data);
-			\PHPStan\dumpType($this->val);
 		}
 	}
 }

tests/PHPStan/Rules/Properties/data/bug-7844b.php

@@ -0,0 +1,39 @@
+<?php
+
+namespace Bug7844b;
+
+class Obj {}
+
+class HelloWorld
+{
+	public Obj $p1;
+	public Obj $p2;
+	public Obj $p3;
+	public Obj $p4;
+	public Obj $p5;
+
+	/** @param non-empty-list<Obj> $objs */
+	public function __construct(array $objs)
+	{
+		\assert($objs !== []);
+		$this->p1 = $objs[0];
+
+		\assert($objs !== []);
+		$this->p2 = $objs[array_key_last($objs)];
+
+		\assert($objs !== []);
+		$this->p3 = \array_pop($objs);
+
+		\assert($objs !== []);
+		$this->p4 = \array_shift($objs);
+
+		\assert($objs !== []);
+		$p = \array_shift($objs);
+		$this->p5 = $p;
+
+		\assert($objs !== []);
+		$this->doSomething(\array_pop($objs));
+	}
+
+	private function doSomething(Obj $obj): void {}
+}

tests/PHPStan/Rules/Variables/ParameterOutAssignedTypeRuleTest.php

@@ -74,9 +74,4 @@ public function testBug13093b(): void
 		$this->analyse([__DIR__ . '/data/bug-13093b.php'], []);
 	}
 
-	public function testBug7844(): void
-	{
-		$this->analyse([__DIR__ . '/data/bug-7844.php'], []);
-	}
-
 }