fix: issue in defined variable rule instead of isset

Author: ga-devfront

src/Rules/IssetCheck.php

@@ -41,14 +41,6 @@ public function __construct(
 	 */
 	public function check(Expr $expr, Scope $scope, string $operatorDescription, string $identifier, callable $typeMessageCallback, ?IdentifierRuleError $error = null): ?IdentifierRuleError
 	{
-		// [FIX] Ignore isset($$foo): dynamic variable
-		if (
-			$expr instanceof Node\Expr\Variable &&
-			$expr->name instanceof Node\Expr\Variable
-		) {
-			return null;
-		}
-
 		// mirrored in PHPStan\Analyser\MutatingScope::issetCheck()
 		if ($expr instanceof Node\Expr\Variable && is_string($expr->name)) {
 			$hasVariable = $scope->hasVariableType($expr->name);

src/Rules/Variables/DefinedVariableRule.php

@@ -41,6 +41,11 @@ public function getNodeType(): string
 	public function processNode(Node $node, Scope $scope): array
 	{
 		$errors = [];
+
+		if ($scope->isUndefinedExpressionAllowed($node)) {
+			return [];
+		}
+
 		if (is_string($node->name)) {
 			$variableNameScopes = [$node->name => $scope];
 		} else {
@@ -78,7 +83,7 @@ private function processSingleVariable(Scope $scope, Variable $node, string $var
 			}
 		}
 
-		if ($scope->isInExpressionAssign($node) || $scope->isUndefinedExpressionAllowed($node)) {
+		if ($scope->isInExpressionAssign($node)) {
 			return [];
 		}
 

tests/PHPStan/Rules/Variables/DefinedVariableRuleTest.php

@@ -1169,4 +1169,13 @@ public function testBug8719(): void
 		$this->analyse([__DIR__ . '/data/bug-8719.php'], []);
 	}
 
+	public function testDynamicVariable(): void
+	{
+		$this->cliArgumentsVariablesRegistered = true;
+		$this->polluteScopeWithLoopInitialAssignments = true;
+		$this->checkMaybeUndefinedVariables = true;
+		$this->polluteScopeWithAlwaysIterableForeach = true;
+
+		$this->analyse([__DIR__ . '/data/dynamic-variable.php'], []);
+	}
 }

tests/PHPStan/Rules/Variables/IssetRuleTest.php

@@ -492,13 +492,6 @@ public function testIssetAfterRememberedConstructor(): void
 		]);
 	}
 
-	public function testDynamicVariable(): void
-	{
-		$this->treatPhpDocTypesAsCertain = true;
-
-		$this->analyse([__DIR__ . '/data/dynamic-variable.php'], []);
-	}
-
 	public function testPr4374(): void
 	{
 		$this->treatPhpDocTypesAsCertain = true;