Faster analysis with a big const array in a class

Author: staabm

src/Type/TypeCombinator.php

@@ -897,6 +897,10 @@ private static function optimizeConstantArrays(array $types): array
 			$keyType = self::union(...$keyTypes);
 			$valueType = self::union(...$valueTypes);
 
+			if ($valueType instanceof UnionType && count($valueType->getTypes()) > ConstantArrayTypeBuilder::ARRAY_COUNT_LIMIT) {
+				$valueType = $valueType->generalize(GeneralizePrecision::lessSpecific());
+			}
+
 			$arrayType = new ArrayType($keyType, $valueType);
 			if ($eachIsList) {
 				$arrayType = self::intersect($arrayType, new AccessoryArrayListType());

tests/PHPStan/Analyser/AnalyserIntegrationTest.php

@@ -1510,6 +1510,16 @@ public function testBug12627(): void
 		$this->assertNoErrors($errors);
 	}
 
+	public function testBug12159(): void
+	{
+		if (PHP_VERSION_ID < 80300) {
+			$this->markTestSkipped('Test requires PHP 8.3.');
+		}
+
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-12159.php');
+		$this->assertNoErrors($errors);
+	}
+
 	/**
 	 * @param string[]|null $allAnalysedFiles
 	 * @return Error[]