Prevent "Unsafe usage of new static() in abstract class" with final constructor

Author: staabm

src/Rules/Classes/NewStaticInAbstractClassStaticMethodRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\Php\PhpMethodFromParserNodeReflection;
+use PHPStan\Reflection\Php\PhpMethodReflection;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use function sprintf;
@@ -49,6 +50,15 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
+		if ($classReflection->hasConstructor()) {
+			$constructor = $classReflection->getConstructor();
+			if (
+				$constructor->isFinal()->yes()
+			) {
+				return [];
+			}
+		}
+
 		return [
 			RuleErrorBuilder::message(sprintf(
 				'Unsafe usage of new static() in abstract class %s in static method %s().',

tests/PHPStan/Rules/Classes/data/new-static-in-abstract-class-static-method.php

@@ -31,3 +31,23 @@ public static function staticDoFoo(): void
 	}
 
 }
+
+abstract class FinalConstructFoo
+{
+	final function __construct() {
+
+	}
+
+	public function doFoo(): void
+	{
+		new static();
+	}
+
+	public static function staticDoFoo(): void
+	{
+		new static();
+	}
+
+}
+
+class Subclass extends FinalConstructFoo {}