Warn about possibly stale result cache with custom extensions

Author: ondrejmirtes

.github/workflows/e2e-tests.yml

@@ -173,6 +173,13 @@ jobs:
               export PHPSTAN_SCOPE_CLASS=MyTestScope
               ACTUAL=$(../../bin/phpstan dump-parameters -c phpstan.neon --json -l 9 | jq --raw-output '.scopeClass')
               [[ "$ACTUAL" == "MyTestScope" ]];
+          - script: |
+              cd e2e/result-cache-8
+              composer install
+              ../../bin/phpstan
+              OUTPUT=$(../../bin/phpstan 2>&1)
+              grep 'Warning: Result cache might not behave correctly' <<< "$OUTPUT"
+              grep 'ResultCache8E2E\\CustomRule' <<< "$OUTPUT"
 
     steps:
       - name: "Checkout"

e2e/result-cache-8/.gitignore

@@ -0,0 +1 @@
+/vendor

e2e/result-cache-8/build/CustomRule.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace ResultCache8E2E;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\Rule;
+
+/**
+ * @implements Rule<Node>
+ */
+class CustomRule implements Rule
+{
+	public function getNodeType(): string
+	{
+		return Node::class;
+	}
+
+	public function processNode(Node $node, Scope $scope): array
+	{
+		return [];
+	}
+
+}

e2e/result-cache-8/build/CustomRule2.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace ResultCache8E2E;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\Rule;
+
+/**
+ * @implements Rule<Node>
+ */
+class CustomRule2 implements Rule
+{
+	public function getNodeType(): string
+	{
+		return Node::class;
+	}
+
+	public function processNode(Node $node, Scope $scope): array
+	{
+		return [];
+	}
+
+}

e2e/result-cache-8/composer.json

@@ -0,0 +1,14 @@
+{
+	"require-dev": {
+		"phpstan/phpstan": "^1.10",
+		"phpstan/phpstan-webmozart-assert": "^1.2"
+	},
+	"autoload": {
+		"classmap": ["src"]
+	},
+	"autoload-dev": {
+		"classmap": [
+			"build"
+		]
+	}
+}

e2e/result-cache-8/composer.lock

@@ -0,0 +1,17 @@
+includes:
+	- vendor/phpstan/phpstan-webmozart-assert/extension.neon
+
+parameters:
+	paths:
+		- src
+	level: 8
+
+rules:
+	- ResultCache8E2E\CustomRule
+	- ResultCache8E2E\CustomRule3
+
+services:
+	-
+		class: ResultCache8E2E\CustomRule2
+		tags:
+			- phpstan.rules.rule

e2e/result-cache-8/phpstan.neon

@@ -0,0 +1,24 @@
+<?php
+
+namespace ResultCache8E2E;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\Rule;
+
+/**
+ * @implements Rule<Node>
+ */
+class CustomRule3 implements Rule
+{
+	public function getNodeType(): string
+	{
+		return Node::class;
+	}
+
+	public function processNode(Node $node, Scope $scope): array
+	{
+		return [];
+	}
+
+}

e2e/result-cache-8/src/CustomRule3.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace ResultCache8E2E;
+
+class Foo
+{
+
+}