Add non regression test

Author: VincentLanglet

tests/PHPStan/Rules/Comparison/BooleanAndConstantConditionRuleTest.php

@@ -425,6 +425,13 @@ public function testReportAlwaysTrueInLastCondition(bool $reportAlwaysTrueInLast
 		$this->analyse([__DIR__ . '/data/boolean-and-report-always-true-last-condition.php'], $expectedErrors);
 	}
 
+	public function testBug4284(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->reportAlwaysTrueInLastCondition = true;
+		$this->analyse([__DIR__ . '/data/bug-4284.php'], []);
+	}
+
 	public function testBug5365(): void
 	{
 		$this->treatPhpDocTypesAsCertain = true;

tests/PHPStan/Rules/Comparison/data/bug-4284.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types = 1);
+
+namespace Bug4284;
+
+class HelloWorld
+{
+	/** @param mixed[] $browser */
+	public function sayHello(array $browser): void
+	{
+		$browserName = '';
+		$upgradeBrowserLink = '';
+
+		if ($browser['name'] === 1) {
+			$browserName = '123';
+			$upgradeBrowserLink = '456';
+		} elseif ($browser['name'] === 2) {
+			$browserName = '789';
+			$upgradeBrowserLink = '123';
+		}
+
+		if ($browserName && $upgradeBrowserLink) {
+			//
+		}
+		if ($browserName) {
+			if ($upgradeBrowserLink) {
+				//
+			}
+		}
+	}
+}