WIP: apply parameter closure type extension in FunctionCallParametersCheck

Author: schlndh

src/Rules/AttributesCheck.php

@@ -127,6 +127,7 @@ public function check(
 				$nodeAttributes['isAttribute'] = true;
 
 				$parameterErrors = $this->functionCallParametersCheck->check(
+					$attributeConstructor,
 					ParametersAcceptorSelector::selectFromArgs(
 						$scope,
 						$attribute->args,

src/Rules/Classes/InstantiationRule.php

@@ -192,6 +192,7 @@ private function checkClassName(string $class, bool $isName, Node $node, Scope $
 		$classDisplayName = SprintfHelper::escapeFormatString($classReflection->getDisplayName());
 
 		return array_merge($messages, $this->check->check(
+			$constructorReflection,
 			ParametersAcceptorSelector::selectFromArgs(
 				$scope,
 				$node->getArgs(),

src/Rules/FunctionCallParametersCheck.php

@@ -6,7 +6,10 @@
 use PhpParser\Node\Expr;
 use PHPStan\Analyser\MutatingScope;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\Type\ParameterClosureTypeExtensionProvider;
 use PHPStan\Php\PhpVersion;
+use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\ParameterReflection;
 use PHPStan\Reflection\ParameterReflectionWithPhpDocs;
 use PHPStan\Reflection\ParametersAcceptor;
@@ -42,6 +45,7 @@ public function __construct(
 		private PhpVersion $phpVersion,
 		private UnresolvableTypeHelper $unresolvableTypeHelper,
 		private PropertyReflectionFinder $propertyReflectionFinder,
+		private ParameterClosureTypeExtensionProvider $parameterClosureTypeExtensionProvider,
 		private bool $checkArgumentTypes,
 		private bool $checkArgumentsPassedByReference,
 		private bool $checkExtraArguments,
@@ -52,12 +56,14 @@ public function __construct(
 	}
 
 	/**
+	 * @param MethodReflection|FunctionReflection|null $callReflection
 	 * @param Node\Expr\FuncCall|Node\Expr\MethodCall|Node\Expr\StaticCall|Node\Expr\New_ $funcCall
 	 * @param array{0: string, 1: string, 2: string, 3: string, 4: string, 5: string, 6: string, 7: string, 8: string, 9: string, 10: string, 11: string, 12: string, 13?: string, 14?: string} $messages
 	 * @param 'attribute'|'callable'|'method'|'staticMethod'|'function'|'new' $nodeType
 	 * @return list<IdentifierRuleError>
 	 */
 	public function check(
+		$callReflection,
 		ParametersAcceptor $parametersAcceptor,
 		Scope $scope,
 		bool $isBuiltin,
@@ -313,6 +319,17 @@ public function check(
 			if ($this->checkArgumentTypes) {
 				$parameterType = TypeUtils::resolveLateResolvableTypes($parameter->getType());
 
+				// TODO: handle other types of extensions
+				if ($funcCall instanceof Expr\FuncCall && $callReflection instanceof FunctionReflection) {
+					foreach ($this->parameterClosureTypeExtensionProvider->getFunctionParameterClosureTypeExtensions() as $functionParameterClosureTypeExtension) {
+						if (!$functionParameterClosureTypeExtension->isFunctionSupported($callReflection, $parameter)) {
+							continue;
+						}
+						$parameterType = $functionParameterClosureTypeExtension->getTypeFromFunctionCall($callReflection, $funcCall, $parameter, $scope) ?? $parameterType;
+
+					}
+				}
+
 				if (
 					!$parameter->passedByReference()->createsNewVariable()
 					|| (!$isBuiltin && $this->checkUnresolvableParameterTypes) // bleeding edge only

src/Rules/Functions/CallCallablesRule.php

@@ -113,6 +113,7 @@ public function processNode(
 		return array_merge(
 			$messages,
 			$this->check->check(
+				null,
 				$parametersAcceptor,
 				$scope,
 				false,

src/Rules/Functions/CallToFunctionParametersRule.php

@@ -40,6 +40,7 @@ public function processNode(Node $node, Scope $scope): array
 		$functionName = SprintfHelper::escapeFormatString($function->getName());
 
 		return $this->check->check(
+			$function,
 			ParametersAcceptorSelector::selectFromArgs(
 				$scope,
 				$node->getArgs(),

src/Rules/Functions/CallUserFuncRule.php

@@ -60,7 +60,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$callableDescription = 'callable passed to call_user_func()';
 
-		return $this->check->check($parametersAcceptor, $scope, false, $funcCall, [
+		return $this->check->check(null, $parametersAcceptor, $scope, false, $funcCall, [
 			ucfirst($callableDescription) . ' invoked with %d parameter, %d required.',
 			ucfirst($callableDescription) . ' invoked with %d parameters, %d required.',
 			ucfirst($callableDescription) . ' invoked with %d parameter, at least %d required.',

src/Rules/Methods/CallMethodsRule.php

@@ -46,6 +46,7 @@ public function processNode(Node $node, Scope $scope): array
 		$messagesMethodName = SprintfHelper::escapeFormatString($declaringClass->getDisplayName() . '::' . $methodReflection->getName() . '()');
 
 		return array_merge($errors, $this->parametersCheck->check(
+			$methodReflection,
 			ParametersAcceptorSelector::selectFromArgs(
 				$scope,
 				$node->getArgs(),

src/Rules/Methods/CallStaticMethodsRule.php

@@ -54,6 +54,7 @@ public function processNode(Node $node, Scope $scope): array
 		));
 
 		$errors = array_merge($errors, $this->parametersCheck->check(
+			$method,
 			ParametersAcceptorSelector::selectFromArgs(
 				$scope,
 				$node->getArgs(),

tests/PHPStan/Analyser/Bug9307CallMethodsRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Analyser;
 
+use PHPStan\DependencyInjection\Type\ParameterClosureTypeExtensionProvider;
 use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\FunctionCallParametersCheck;
 use PHPStan\Rules\Methods\CallMethodsRule;
@@ -26,7 +27,7 @@ protected function getRule(): Rule
 		$ruleLevelHelper = new RuleLevelHelper($reflectionProvider, true, false, true, true, false, true, false);
 		return new CallMethodsRule(
 			new MethodCallCheck($reflectionProvider, $ruleLevelHelper, true, true),
-			new FunctionCallParametersCheck($ruleLevelHelper, new NullsafeCheck(), new PhpVersion(PHP_VERSION_ID), new UnresolvableTypeHelper(), new PropertyReflectionFinder(), true, true, true, true, true),
+			new FunctionCallParametersCheck($ruleLevelHelper, new NullsafeCheck(), new PhpVersion(PHP_VERSION_ID), new UnresolvableTypeHelper(), new PropertyReflectionFinder(), self::getContainer()->getByType(ParameterClosureTypeExtensionProvider::class), true, true, true, true, true),
 		);
 	}
 

tests/PHPStan/Rules/Classes/ClassAttributesRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Classes;
 
+use PHPStan\DependencyInjection\Type\ParameterClosureTypeExtensionProvider;
 use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\AttributesCheck;
 use PHPStan\Rules\ClassCaseSensitivityCheck;
@@ -34,6 +35,7 @@ protected function getRule(): Rule
 					new PhpVersion(80000),
 					new UnresolvableTypeHelper(),
 					new PropertyReflectionFinder(),
+					self::getContainer()->getByType(ParameterClosureTypeExtensionProvider::class),
 					true,
 					true,
 					true,