DOMNode::hasAttributes() assertions

Author: Girgias

stubs/dom.stub

@@ -34,6 +34,12 @@ class DOMNode
 	 * @var DOMNamedNodeMap<DOMAttr>|null
 	 */
 	public $attributes;
+
+	/**
+	 * @phpstan-assert-if-true DOMNamedNodeMap<DOMAttr> $this->attributes
+	 * @phpstan-assert-if-false null $this->attributes
+	 */
+	public function hasAttributes(): bool {}
 }
 
 class DOMElement extends DOMNode

tests/PHPStan/Rules/Properties/data/dom-legacy-ext-template-nodes.php

@@ -3,16 +3,9 @@
 use function PHPStan\Testing\assertType;
 
 function basic_node(\DOMNode $node): void {
-	assertType(DOMNamedNodeMap::class . '<' . DOMAttr::class . '>', $node->attributes);
-};
-
-function element_node(\DOMElement $node): void
-{
-	assertType(DOMNamedNodeMap::class . '<' . DOMAttr::class . '>', $node->attributes);
-	$attribute = $node->attributes->getNamedItem('class');
-	if ($attribute === null) {
-		return;
+	if ($node->hasAttributes()) {
+		assertType(DOMNamedNodeMap::class . '<' . DOMAttr::class . '>', $node->attributes);
+	} else {
+		assertType('null', $node->attributes);
 	}
-	assertType(DOMAttr::class, $attribute);
-	assertType('string', $attribute->value);
-}
+};