Access Union::getObjectClassReflections

Author: VincentLanglet

src/Rules/PhpDoc/RequireExtendsCheck.php

@@ -12,6 +12,7 @@
 use PHPStan\Rules\ClassNameUsageLocation;
 use PHPStan\Rules\IdentifierRuleError;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\Type\UnionType;
 use PHPStan\Type\VerbosityLevel;
 use function array_column;
 use function array_map;
@@ -59,8 +60,18 @@ public function checkExtendsTags(Scope $scope, Node $node, array $extendsTags):
 				continue;
 			}
 
+			if ($type instanceof UnionType) {
+				$classReflections = [];
+				foreach ($type->getTypes() as $subType) {
+					$classReflections[] = $subType->getObjectClassReflections();
+				}
+				$classReflections = array_merge(...$classReflections);
+			} else {
+				$classReflections = $type->getObjectClassReflections();
+			}
+
 			sort($classNames);
-			$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $type->getObjectClassReflections());
+			$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $classReflections);
 			$referencedClassReflectionsMap = array_column($referencedClassReflections, 0, 1);
 			foreach ($classNames as $class) {
 				$referencedClassReflection = $referencedClassReflectionsMap[$class] ?? null;

src/Rules/PhpDoc/RequireImplementsDefinitionTraitRule.php

@@ -12,6 +12,7 @@
 use PHPStan\Rules\ClassNameUsageLocation;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\Type\UnionType;
 use PHPStan\Type\VerbosityLevel;
 use function array_column;
 use function array_map;
@@ -66,7 +67,17 @@ public function processNode(Node $node, Scope $scope): array
 				continue;
 			}
 
-			$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $type->getObjectClassReflections());
+			if ($type instanceof UnionType) {
+				$classReflections = [];
+				foreach ($type->getTypes() as $subType) {
+					$classReflections[] = $subType->getObjectClassReflections();
+				}
+				$classReflections = array_merge(...$classReflections);
+			} else {
+				$classReflections = $type->getObjectClassReflections();
+			}
+
+			$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $classReflections);
 			$referencedClassReflectionsMap = array_column($referencedClassReflections, 0, 1);
 			foreach ($classNames as $class) {
 				$referencedClassReflection = $referencedClassReflectionsMap[$class] ?? null;

src/Rules/PhpDoc/SealedDefinitionClassRule.php

@@ -12,6 +12,7 @@
 use PHPStan\Rules\ClassNameUsageLocation;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\Type\UnionType;
 use PHPStan\Type\VerbosityLevel;
 use function array_column;
 use function array_map;
@@ -69,7 +70,17 @@ public function processNode(Node $node, Scope $scope): array
 				continue;
 			}
 
-			$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $type->getObjectClassReflections());
+			if ($type instanceof UnionType) {
+				$classReflections = [];
+				foreach ($type->getTypes() as $subType) {
+					$classReflections[] = $subType->getObjectClassReflections();
+				}
+				$classReflections = array_merge(...$classReflections);
+			} else {
+				$classReflections = $type->getObjectClassReflections();
+			}
+
+			$referencedClassReflections = array_map(static fn ($reflection) => [$reflection, $reflection->getName()], $classReflections);
 			$referencedClassReflectionsMap = array_column($referencedClassReflections, 0, 1);
 			foreach ($classNames as $class) {
 				$referencedClassReflection = $referencedClassReflectionsMap[$class] ?? null;

tests/PHPStan/Rules/PhpDoc/SealedDefinitionClassRuleTest.php

@@ -49,6 +49,11 @@ public function testRule(): void
 				26,
 				'Learn more at https://phpstan.org/user-guide/discovering-symbols',
 			],
+			[
+				'PHPDoc tag @phpstan-sealed contains unknown class IncompatibleSealed\UnknownClass.',
+				46,
+				'Learn more at https://phpstan.org/user-guide/discovering-symbols',
+			],
 		]);
 	}
 

tests/PHPStan/Rules/PhpDoc/data/incompatible-sealed.php

@@ -39,3 +39,8 @@ interface ValidInterface {}
  * @phpstan-sealed SomeInterface
  */
 interface ValidInterface2 {}
+
+/**
+ * @phpstan-sealed UnknownClass|SomeClass
+ */
+class InvalidClassWithUnion {}