test overwriting elements

Author: staabm

src/Type/Accessory/AccessoryArrayListType.php

@@ -151,6 +151,13 @@ public function setOffsetValueType(?Type $offsetType, Type $valueType, bool $uni
 			return $this;
 		}
 
+		if (
+			$valueType->isArray()->yes()
+			&& IntegerRangeType::fromInterval(0, null)->isSuperTypeOf($offsetType)->yes()
+		) {
+			return $this;
+		}
+
 		return new ErrorType();
 	}
 

tests/PHPStan/Rules/Methods/data/bug-12927.php

@@ -22,15 +22,42 @@ public function sayHello(array $list): array
 
 	/**
 	 * @param list<array<string, string>> $list
-	 * @return list<array<string>>
 	 */
-	public function sayFoo(array $list): array
+	public function sayFoo(array $list): void
 	{
 		foreach($list as $k => $v) {
 			unset($list[$k]['abc']);
 			assertType('non-empty-list<array<string, string>>', $list);
 			assertType('array<string, string>', $list[$k]);
 		}
-		return $list;
+		assertType('list<array<string, string>>', $list);
+	}
+
+	/**
+	 * @param list<array<string, string>> $list
+	 */
+	public function sayFoo2(array $list): void
+	{
+		foreach($list as $k => $v) {
+			$list[$k]['abc'] = 'world';
+			assertType("non-empty-list<non-empty-array<string, string>&hasOffsetValue('abc', 'world')>", $list);
+			assertType("non-empty-array<string, string>&hasOffsetValue('abc', 'world')", $list[$k]);
+		}
+		assertType("list<non-empty-array<string, string>&hasOffsetValue('abc', 'world')>", $list);
+	}
+
+	/**
+	 * @param list<array<string, string>> $list
+	 */
+	public function sayFooBar(array $list): void
+	{
+		foreach($list as $k => $v) {
+			if (rand(0,1)) {
+				unset($list[$k]);
+			}
+			assertType('array<int<0, max>, array<string, string>>', $list);
+			assertType('array<string, string>', $list[$k]);
+		}
+		assertType('array<string, string>', $list[$k]);
 	}
 }