SetPropertyHookParameterRule - level 0 and 3

Author: ondrejmirtes

conf/config.level0.neon

@@ -212,6 +212,13 @@ services:
 		tags:
 			- phpstan.rules.rule
 
+	-
+		class: PHPStan\Rules\Properties\SetPropertyHookParameterRule
+		arguments:
+			checkPhpDocMethodSignatures: %checkPhpDocMethodSignatures%
+		tags:
+			- phpstan.rules.rule
+
 	-
 		class: PHPStan\Rules\Properties\UninitializedPropertyRule
 

src/Rules/Properties/SetPropertyHookParameterRule.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Properties;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Node\InPropertyHookNode;
+use PHPStan\Rules\Rule;
+
+/**
+ * @implements Rule<InPropertyHookNode>
+ */
+class SetPropertyHookParameterRule implements Rule
+{
+
+	public function __construct(private bool $checkPhpDocMethodSignatures)
+	{
+	}
+
+	public function getNodeType(): string
+	{
+		return InPropertyHookNode::class;
+	}
+
+	public function processNode(Node $node, Scope $scope): array
+	{
+		return [];
+	}
+
+}

tests/PHPStan/Rules/Properties/SetPropertyHookParameterRuleTest.php

@@ -0,0 +1,29 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Properties;
+
+use PHPStan\Rules\Rule as TRule;
+use PHPStan\Testing\RuleTestCase;
+use const PHP_VERSION_ID;
+
+/**
+ * @extends RuleTestCase<SetPropertyHookParameterRule>
+ */
+class SetPropertyHookParameterRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): TRule
+	{
+		return new SetPropertyHookParameterRule(true);
+	}
+
+	public function testRule(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4.');
+		}
+
+		$this->analyse([__DIR__ . '/data/set-property-hook-parameter.php'], []);
+	}
+
+}

tests/PHPStan/Rules/Properties/data/set-property-hook-parameter.php

@@ -0,0 +1,78 @@
+<?php // lint >= 8.4
+
+namespace SetPropertyHookParameter;
+
+class Foo
+{
+
+	public int $ok {
+		set (int $v) {
+
+		}
+	}
+
+	/** @var positive-int */
+	public int $ok2 {
+		set (int $v) {
+
+		}
+	}
+
+	/** @var positive-int */
+	public int $ok3 {
+		/** @param positive-int|array<string> */
+		set (int|array $v) {
+
+		}
+	}
+
+	public $ok4 {
+		set ($v) {
+
+		}
+	}
+
+}
+
+class Bar
+{
+
+	public $a {
+		set (int $v) {
+
+		}
+	}
+
+	public int $b {
+		set ($v) {
+
+		}
+	}
+
+	public int $c {
+		set (string $v) {
+
+		}
+	}
+
+	public int|string $d {
+		set (string $v) {
+
+		}
+	}
+
+	public int $e {
+		/** @param positive-int */
+		set (int $v) {
+
+		}
+	}
+
+	public int $f {
+		/** @param positive-int|array<string> */
+		set (int|array $v) {
+
+		}
+	}
+
+}