Downgrade PHPUnit on 7.4 and 8.0

ondrejmirtes · ondrejmirtes · commit a57c603f7b21 · 2025-06-06T20:47:25.000+02:00
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -39,11 +39,15 @@ jobs:
           coverage: "none"
           php-version: "${{ matrix.php-version }}"
 
+      - name: "Downgrade PHPUnit"
+        if: matrix.php-version == '7.4' || matrix.php-version == '8.0'
+        run: "composer require --dev phpunit/phpunit:^9.6 sebastian/diff:^4.0 --update-with-dependencies --ignore-platform-reqs"
+
       - name: "Install dependencies"
         run: "composer install --no-interaction --no-progress"
 
       - name: "Transform source code"
-        if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
+        if: matrix.php-version == '7.4' || matrix.php-version == '8.0'
         run: |
           composer install --no-interaction --no-progress --working-dir=compiler
           ./compiler/vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}
diff --git a/.github/workflows/phar.yml b/.github/workflows/phar.yml
@@ -41,6 +41,10 @@ jobs:
       - name: "Install dependencies"
         run: "composer install --no-interaction --no-progress"
 
+      # only sebastian/diff ^4 supports PHP 7.4 so we need that in the PHAR
+      - name: "Downgrade PHPUnit"
+        run: "composer require --dev phpunit/phpunit:^9.6 sebastian/diff:^4.0 --update-with-dependencies --ignore-platform-reqs"
+
       - name: "Install compiler dependencies"
         run: "composer install --no-interaction --no-progress --working-dir=compiler"
 
diff --git a/.github/workflows/reflection-golden-test.yml b/.github/workflows/reflection-golden-test.yml
@@ -100,7 +100,7 @@ jobs:
         run: "composer install --no-interaction --no-progress"
 
       - name: "Transform source code"
-        if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
+        if: matrix.php-version == '7.4' || matrix.php-version == '8.0'
         run: |
           composer install --no-interaction --no-progress --working-dir=compiler
           ./compiler/vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}
@@ -118,11 +118,15 @@ jobs:
       - name: "Checkout"
         uses: actions/checkout@v4
 
+      - name: "Downgrade PHPUnit"
+        if: matrix.php-version == '7.4' || matrix.php-version == '8.0'
+        run: "composer require --dev phpunit/phpunit:^9.6 sebastian/diff:^4.0 --update-with-dependencies --ignore-platform-reqs"
+
       - name: "Install dependencies"
         run: "composer install --no-interaction --no-progress"
 
       - name: "Transform source code"
-        if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
+        if: matrix.php-version == '7.4' || matrix.php-version == '8.0'
         run: |
           composer install --no-interaction --no-progress --working-dir=compiler
           ./compiler/vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}
diff --git a/.github/workflows/static-analysis.yml b/.github/workflows/static-analysis.yml
@@ -48,18 +48,22 @@ jobs:
           ini-file: development
           extensions: mbstring
 
+      - name: "Downgrade PHPUnit"
+        if: matrix.php-version == '7.4' || matrix.php-version == '8.0'
+        shell: bash
+        run: "composer require --dev phpunit/phpunit:^9.6 sebastian/diff:^4.0 --update-with-dependencies --ignore-platform-reqs"
+
       - name: "Install dependencies"
         run: "composer install --no-interaction --no-progress"
 
       - name: "Transform source code"
-        if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
+        if: matrix.php-version == '7.4' || matrix.php-version == '8.0'
         shell: bash
         run: |
           composer install --no-interaction --no-progress --working-dir=compiler
           ./compiler/vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}
           composer dump
 
-
       - name: "PHPStan"
         run: "make phpstan"
 
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -107,8 +107,8 @@ jobs:
           ini-file: development
           ini-values: memory_limit=1G
 
-      - name: "Install PHPUnit 10.x"
-        run: "composer remove --dev brianium/paratest && composer require --dev --with-all-dependencies phpunit/phpunit:^10 sebastian/diff:^5.0"
+      - name: "Install dependencies"
+        run: "composer install --no-interaction --no-progress"
 
       - id: set-matrix
         run: echo "matrix=$(php .github/workflows/tests-levels-matrix.php)" >> $GITHUB_OUTPUT
@@ -175,12 +175,13 @@ jobs:
           ini-file: development
           ini-values: memory_limit=2G
 
+      - name: "Downgrade PHPUnit"
+        shell: bash
+        run: "composer require --dev phpunit/phpunit:^9.6 sebastian/diff:^4.0 --update-with-dependencies --ignore-platform-reqs"
+
       - name: "Install dependencies"
         run: "composer install --no-interaction --no-progress"
 
-      - name: "Downgrade PHPUnit"
-        run: "composer require --dev phpunit/phpunit:^9.6 --update-with-dependencies"
-
       - name: "Transform source code"
         shell: bash
         run: |
diff --git a/build/ignore-by-php-version.neon.php b/build/ignore-by-php-version.neon.php
@@ -33,6 +33,11 @@
 	$includes[] = __DIR__ . '/deprecated-8.4.neon';
 }
 
+if (PHP_VERSION_ID < 80100) {
+	$includes[] = __DIR__ . '/old-phpunit.neon';
+} else {
+	$includes[] = __DIR__ . '/new-phpunit.neon';
+}
 $config = [];
 $config['includes'] = $includes;
 
diff --git a/build/new-phpunit.neon b/build/new-phpunit.neon
@@ -0,0 +1,7 @@
+parameters:
+	ignoreErrors:
+		-
+			message: '#^Call to an undefined static method PHPUnit\\Framework\\TestCase\:\:assertFileNotExists\(\)\.$#'
+			identifier: staticMethod.notFound
+			count: 1
+			path: ../src/Testing/LevelsTestCase.php
diff --git a/build/old-phpunit.neon b/build/old-phpunit.neon
@@ -0,0 +1,16 @@
+parameters:
+	ignoreErrors:
+			-
+				message: '#^Instanceof references internal interface PHPUnit\\Exception\.$#'
+				identifier: instanceof.internalInterface
+				count: 1
+				path: ../tests/PHPStan/Reflection/ReflectionProviderGoldenTest.php
+
+			-
+				message: '''
+					#^Call to deprecated method assertFileNotExists\(\) of class PHPUnit\\Framework\\Assert\:
+					https\://github\.com/sebastianbergmann/phpunit/issues/4077$#
+				'''
+				identifier: staticMethod.deprecated
+				count: 1
+				path: src/Testing/LevelsTestCase.php
diff --git a/composer.json b/composer.json
@@ -38,7 +38,7 @@
 		"react/promise": "^3.2",
 		"react/socket": "^1.3",
 		"react/stream": "^1.1",
-		"sebastian/diff": "^4.0 || ^5.0",
+		"sebastian/diff": "^5.0",
 		"symfony/console": "^5.4.3",
 		"symfony/finder": "^5.4.3",
 		"symfony/polyfill-intl-grapheme": "^1.23",
diff --git a/composer.lock b/composer.lock
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -747,12 +747,6 @@ parameters:
 			count: 1
 			path: src/Rules/RuleLevelHelper.php
 
-		-
-			message: '#^Call to an undefined static method PHPUnit\\Framework\\TestCase\:\:assertFileNotExists\(\)\.$#'
-			identifier: staticMethod.notFound
-			count: 1
-			path: src/Testing/LevelsTestCase.php
-
 		-
 			message: '#^Call to function method_exists\(\) with ''PHPUnit\\\\Framework\\\\TestCase'' and ''assertFileDoesNotEx…'' will always evaluate to true\.$#'
 			identifier: function.alreadyNarrowedType
