adjust tests

Author: staabm

tests/PHPStan/Rules/TooWideTypehints/TooWideFunctionReturnTypehintRuleTest.php

@@ -94,6 +94,10 @@ public function testBug13384cPhp82(): void
 				'Function Bug13384c\doFooPhpdoc2() never returns true so the return type can be changed to false.',
 				100,
 			],
+			[
+				'Function Bug13384c\callsReturnsTrue() never returns false so the return type can be changed to true.',
+				122,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/TooWideTypehints/data/bug-13384c.php

@@ -3,11 +3,11 @@
 namespace Bug13384c;
 
 function doFoo(): bool {
-	return false;
+	return returnsFalse();
 }
 
 function doFoo2(): bool {
-	return true;
+	return returnsTrue();
 }
 
 function doFoo3(): bool {
@@ -20,22 +20,22 @@ function doFoo3(): bool {
 
 class Bug13384c {
 	public function doBarPublic(): bool {
-		return false;
+		return returnsFalse();
 	}
 
 	/**
 	 * @return false
 	 */
 	private function doBarPhpdocReturn(): bool {
-		return false;
+		return returnsFalse();
 	}
 
 	private function doBar(): bool {
-		return false;
+		return returnsFalse();
 	}
 
 	private function doBar2(): bool {
-		return true;
+		return returnsTrue();
 	}
 
 	private function doBar3(): bool {
@@ -46,25 +46,25 @@ private function doBar3(): bool {
 	}
 
 	private function doBarMixed() {
-		return true;
+		return returnsTrue();
 	}
 
 	/**
 	 * @return bool
 	 */
 	private function doBarPhpdoc() {
-		return true;
+		return returnsTrue();
 	}
 
 }
 
 class Bug13384Static {
 	private static function doBar(): bool {
-		return false;
+		return returnsFalse();
 	}
 
 	private static function doBar2(): bool {
-		return true;
+		return returnsTrue();
 	}
 
 	private static function doBar3(): bool {
@@ -75,14 +75,14 @@ private static function doBar3(): bool {
 	}
 
 	private static function doBarMixed() {
-		return true;
+		return returnsTrue();
 	}
 
 	/**
 	 * @return bool
 	 */
 	private static function doBarPhpdoc() {
-		return true;
+		return returnsTrue();
 	}
 
 }
@@ -91,18 +91,18 @@ private static function doBarPhpdoc() {
  * @return bool
  */
 function doFooPhpdoc() {
-	return true;
+	return returnsTrue();
 }
 
 /**
  * @return bool
  */
 function doFooPhpdoc2() {
-	return false;
+	return returnsFalse();
 }
 
 function doFooMixed() {
-	return true;
+	return returnsTrue();
 }
 
 /**
@@ -112,6 +112,13 @@ function returnsTrue(): bool {
 	return true;
 }
 
+/**
+ * @return false
+ */
+function returnsFalse(): bool {
+	return false;
+}
+
 function callsReturnsTrue(): bool {
 	return returnsTrue();
 }