Add reportPossiblyNonexistentStringOffset parameter

Author: staabm

conf/bleedingEdge.neon

@@ -5,3 +5,4 @@ parameters:
 		skipCheckGenericClasses!: []
 		stricterFunctionMap: true
 		reportPreciseLineForUnusedFunctionParameter: true
+		reportPossiblyNonexistentStringOffset: true

conf/config.neon

@@ -63,6 +63,7 @@ parameters:
 	reportAnyTypeWideningInVarTag: false
 	reportPossiblyNonexistentGeneralArrayOffset: false
 	reportPossiblyNonexistentConstantArrayOffset: false
+	reportPossiblyNonexistentStringOffset: false
 	checkMissingOverrideMethodAttribute: false
 	mixinExcludeClasses: []
 	scanFiles: []
@@ -837,6 +838,7 @@ services:
 			reportMaybes: %reportMaybes%
 			reportPossiblyNonexistentGeneralArrayOffset: %reportPossiblyNonexistentGeneralArrayOffset%
 			reportPossiblyNonexistentConstantArrayOffset: %reportPossiblyNonexistentConstantArrayOffset%
+			reportPossiblyNonexistentStringOffset: %reportPossiblyNonexistentStringOffset%
 
 	-
 		class: PHPStan\Rules\ClassNameCheck

conf/parametersSchema.neon

@@ -74,6 +74,7 @@ parametersSchema:
 	reportAnyTypeWideningInVarTag: bool()
 	reportPossiblyNonexistentGeneralArrayOffset: bool()
 	reportPossiblyNonexistentConstantArrayOffset: bool()
+	reportPossiblyNonexistentStringOffset: bool()
 	checkMissingOverrideMethodAttribute: bool()
 	parallel: structure([
 		jobSize: int(),

src/Rules/Arrays/NonexistentOffsetInArrayDimFetchCheck.php

@@ -26,6 +26,7 @@ public function __construct(
 		private bool $reportMaybes,
 		private bool $reportPossiblyNonexistentGeneralArrayOffset,
 		private bool $reportPossiblyNonexistentConstantArrayOffset,
+		private bool $reportPossiblyNonexistentStringOffset,
 	)
 	{
 	}
@@ -68,8 +69,9 @@ public function check(
 
 			$zeroOrMore = IntegerRangeType::fromInterval(0, null);
 			if (
-				$type->isString()->yes()
-				&& $dimType->isInteger()->yes()
+				$this->reportPossiblyNonexistentStringOffset
+				&& $type->isString()->yes()
+				&& $dimType instanceof IntegerRangeType
 				&& !$zeroOrMore->isSuperTypeOf($dimType)->yes()
 			) {
 				$report = true;

tests/PHPStan/Rules/Arrays/ArrayDestructuringRuleTest.php

@@ -19,7 +19,7 @@ protected function getRule(): Rule
 
 		return new ArrayDestructuringRule(
 			$ruleLevelHelper,
-			new NonexistentOffsetInArrayDimFetchCheck($ruleLevelHelper, true, false, false),
+			new NonexistentOffsetInArrayDimFetchCheck($ruleLevelHelper, true, false, false, false),
 		);
 	}
 

tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php

@@ -21,13 +21,15 @@ class NonexistentOffsetInArrayDimFetchRuleTest extends RuleTestCase
 
 	private bool $reportPossiblyNonexistentConstantArrayOffset = false;
 
+	private bool $reportPossiblyNonexistentStringOffset = false;
+
 	protected function getRule(): Rule
 	{
 		$ruleLevelHelper = new RuleLevelHelper($this->createReflectionProvider(), true, false, true, $this->checkExplicitMixed, $this->checkImplicitMixed, false);
 
 		return new NonexistentOffsetInArrayDimFetchRule(
 			$ruleLevelHelper,
-			new NonexistentOffsetInArrayDimFetchCheck($ruleLevelHelper, true, $this->reportPossiblyNonexistentGeneralArrayOffset, $this->reportPossiblyNonexistentConstantArrayOffset),
+			new NonexistentOffsetInArrayDimFetchCheck($ruleLevelHelper, true, $this->reportPossiblyNonexistentGeneralArrayOffset, $this->reportPossiblyNonexistentConstantArrayOffset, $this->reportPossiblyNonexistentStringOffset),
 			true,
 		);
 	}
@@ -782,6 +784,8 @@ public function testInternalClassesWithOverloadedOffsetAccessInvalid84(): void
 
 	public function testBug11946(): void
 	{
+		$this->reportPossiblyNonexistentStringOffset = true;
+
 		$this->analyse([__DIR__ . '/data/bug-11946.php'], [
 			[
 				'Offset -1 does not exist on string.',
@@ -805,23 +809,23 @@ public function testBug11946(): void
 			],
 			[
 				'Offset int<-5, 5> might not exist on string.',
-				45
+				45,
 			],
 			[
 				'Offset int<-5, 5> might not exist on numeric-string.',
-				46
+				46,
 			],
 			[
 				'Offset int<-5, 5> might not exist on non-empty-string.',
-				47
+				47,
 			],
 			[
 				'Offset int<-5, 5> might not exist on non-falsy-string.',
-				48
+				48,
 			],
 			[
 				'Offset int<-5, 5> might not exist on string.',
-				49
+				49,
 			],
 		]);
 	}

tests/PHPStan/Rules/Arrays/data/bug-11946.php

@@ -15,7 +15,7 @@ public function nonExistentStringOffset(
 		string $numericS,
 		string $nonEmpty,
 		string $nonFalsy,
-		string $lowerCase,
+		string $lowerCase
 	)
 	{
 		echo $s[-1];