Fix 10367

Author: VincentLanglet

src/Type/Php/ArrayColumnHelper.php

@@ -145,7 +145,7 @@ private function getOffsetOrProperty(Type $type, Type $offsetOrProperty, Scope $
 		if (!$type->canAccessProperties()->no()) {
 			$propertyTypes = $offsetOrProperty->getConstantStrings();
 			if ($propertyTypes === []) {
-				return new MixedType();
+				return $allowMaybe ? new MixedType() : null;
 			}
 			foreach ($propertyTypes as $propertyType) {
 				$propertyName = $propertyType->getValue();

tests/PHPStan/Rules/Variables/EmptyRuleTest.php

@@ -207,6 +207,13 @@ public function testBug12658(): void
 		$this->analyse([__DIR__ . '/data/bug-12658.php'], []);
 	}
 
+	public function testBug10367(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+
+		$this->analyse([__DIR__ . '/data/bug-10367.php'], []);
+	}
+
 	#[RequiresPhp('>= 8.0')]
 	public function testIssetAfterRememberedConstructor(): void
 	{

tests/PHPStan/Rules/Variables/data/bug-10367.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types = 1);
+
+namespace Bug10367;
+
+final class PackingSlipPdf
+{
+	public function __construct(array $packingSlipItems, string $fullName)
+	{
+		if (empty($packingSlipItems)) {
+			error_log('$packingSlipItems is empty: check company: ' . $fullName);
+		} else {
+			$freightNumbers = array_column($packingSlipItems, 3);
+			if (empty($freightNumbers)) {
+				error_log('$freightNumbers is empty: check company: ' . $fullName);
+				error_log('$freightNumbers is empty: check dataset: ' . print_r($packingSlipItems[0], true));
+			} elseif (empty($freightNumbers[0])) {
+				error_log('$freightNumbers[0] is empty: check company: ' . $fullName);
+				error_log('$freightNumbers[0] is empty: check freigthnumbers: ' . print_r($freightNumbers, true));
+				error_log('$freightNumbers[0] is empty: check dataset: ' . print_r($packingSlipItems[0], true));
+			}
+		}
+	}
+}
+
+$testArray = [
+	[1 => 123, 2 => 413, 4 => 132],
+	[1 => 123, 2 => 413, 4 => 132],
+];
+
+$packingSlipPdf = new PackingSlipPdf($testArray, "TestName");