Precise line only for BleedingEdge

Author: janedbal

conf/config.neon

@@ -1043,6 +1043,8 @@ services:
 
 	-
 		class: PHPStan\Rules\UnusedFunctionParametersCheck
+		arguments:
+			reportExactLine: %featureToggles.bleedingEdge%
 
 	-
 		class: PHPStan\Rules\TooWideTypehints\TooWideParameterOutTypeCheck

src/Rules/UnusedFunctionParametersCheck.php

@@ -18,7 +18,10 @@
 final class UnusedFunctionParametersCheck
 {
 
-	public function __construct(private ReflectionProvider $reflectionProvider)
+	public function __construct(
+		private ReflectionProvider $reflectionProvider,
+		private bool $reportExactLine,
+	)
 	{
 	}
 
@@ -52,9 +55,11 @@ public function getUnusedParameters(
 		}
 		$errors = [];
 		foreach ($unusedParameters as $name => $variable) {
-			$errors[] = RuleErrorBuilder::message(
-				sprintf($unusedParameterMessage, $name),
-			)->identifier($identifier)->line($variable->getStartLine())->build();
+			$errorBuilder = RuleErrorBuilder::message(sprintf($unusedParameterMessage, $name))->identifier($identifier);
+			if ($this->reportExactLine) {
+				$errorBuilder->line($variable->getStartLine());
+			}
+			$errors[] = $errorBuilder->build();
 		}
 
 		return $errors;

tests/PHPStan/Rules/Classes/UnusedConstructorParametersRuleTest.php

@@ -12,13 +12,31 @@
 class UnusedConstructorParametersRuleTest extends RuleTestCase
 {
 
+	private bool $reportExactLine = true;
+
 	protected function getRule(): Rule
 	{
 		return new UnusedConstructorParametersRule(new UnusedFunctionParametersCheck(
 			$this->createReflectionProvider(),
+			$this->reportExactLine,
 		));
 	}
 
+	public function testUnusedConstructorParametersNoExactLine(): void
+	{
+		$this->reportExactLine = false;
+		$this->analyse([__DIR__ . '/data/unused-constructor-parameters.php'], [
+			[
+				'Constructor of class UnusedConstructorParameters\Foo has an unused parameter $unusedParameter.',
+				11,
+			],
+			[
+				'Constructor of class UnusedConstructorParameters\Foo has an unused parameter $anotherUnusedParameter.',
+				11,
+			],
+		]);
+	}
+
 	public function testUnusedConstructorParameters(): void
 	{
 		$this->analyse([__DIR__ . '/data/unused-constructor-parameters.php'], [

tests/PHPStan/Rules/Functions/UnusedClosureUsesRuleTest.php

@@ -14,7 +14,7 @@ class UnusedClosureUsesRuleTest extends RuleTestCase
 
 	protected function getRule(): Rule
 	{
-		return new UnusedClosureUsesRule(new UnusedFunctionParametersCheck($this->createReflectionProvider()));
+		return new UnusedClosureUsesRule(new UnusedFunctionParametersCheck($this->createReflectionProvider(), true));
 	}
 
 	public function testUnusedClosureUses(): void