Differ cannot be a service after all

Author: ondrejmirtes

conf/services.neon

@@ -160,17 +160,6 @@ services:
 	-
 		class: PHPStan\Rules\Properties\UninitializedPropertyRule
 
-	-
-		class: SebastianBergmann\Diff\Differ
-		arguments:
-			outputBuilder: @SebastianBergmann\Diff\Output\UnifiedDiffOutputBuilder
-
-	-
-		class: SebastianBergmann\Diff\Output\UnifiedDiffOutputBuilder
-		arguments:
-			header: ''
-			addLineNumbers: true
-
 	betterReflectionSourceLocator:
 		class: PHPStan\BetterReflection\SourceLocator\Type\SourceLocator
 		factory: @PHPStan\Reflection\BetterReflection\BetterReflectionSourceLocatorFactory::create

src/Analyser/RuleErrorTransformer.php

@@ -23,18 +23,21 @@
 use PHPStan\Rules\TipRuleError;
 use PHPStan\ShouldNotHappenException;
 use SebastianBergmann\Diff\Differ;
+use SebastianBergmann\Diff\Output\UnifiedDiffOutputBuilder;
 use function get_class;
 use function sha1;
 use function str_repeat;
 
 final class RuleErrorTransformer
 {
 
+	private Differ $differ;
+
 	public function __construct(
 		private Parser $parser,
-		private Differ $differ,
 	)
 	{
+		$this->differ = new Differ(new UnifiedDiffOutputBuilder('', addLineNumbers: true));
 	}
 
 	/**

src/Fixable/Patcher.php

@@ -25,8 +25,11 @@
 final class Patcher
 {
 
-	public function __construct(private Differ $differ)
+	private Differ $differ;
+
+	public function __construct()
 	{
+		$this->differ = new Differ();
 	}
 
 	/**