Improve

Author: VincentLanglet

src/Php/PhpVersion.php

@@ -236,7 +236,7 @@ public function deprecatesDynamicProperties(): bool
 		return $this->versionId >= 80200;
 	}
 
-	public function strSplitReturnsEmptyArray(): bool
+	public function strSplitReturnsEmptyArrayOnEmptyString(): bool
 	{
 		return $this->versionId >= 80200;
 	}

src/Type/Php/StrSplitFunctionReturnTypeExtension.php

@@ -91,9 +91,16 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 			if (count($constantStrings) > 0) {
 				$results = [];
 				foreach ($constantStrings as $constantString) {
-					$items = $encoding === null
-						? str_split($constantString->getValue(), $splitLength)
-						: @mb_str_split($constantString->getValue(), $splitLength, $encoding);
+					$value = $constantString->getValue();
+
+					if ($encoding === null && $value === '') {
+						// Simulate the str_split call with the analysed PHP Version instead of the runtime one.
+						$items = $this->phpVersion->strSplitReturnsEmptyArrayOnEmptyString() ? [] : [''];
+					} else {
+						$items = $encoding === null
+							? str_split($value, $splitLength)
+							: @mb_str_split($value, $splitLength, $encoding);
+					}
 
 					$results[] = self::createConstantArrayFrom($items, $scope);
 				}
@@ -104,7 +111,7 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 
 		$isInputNonEmptyString = $stringType->isNonEmptyString()->yes();
 
-		if ($isInputNonEmptyString || $this->phpVersion->strSplitReturnsEmptyArray()) {
+		if ($isInputNonEmptyString || $this->phpVersion->strSplitReturnsEmptyArrayOnEmptyString()) {
 			$returnValueType = TypeCombinator::intersect(new StringType(), new AccessoryNonEmptyStringType());
 		} else {
 			$returnValueType = new StringType();
@@ -115,7 +122,7 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 			// Non-empty-string will return an array with at least an element
 			$isInputNonEmptyString
 			// str_split('', 1) returns [''] on old PHP version and [] on new ones
-			|| ($functionReflection->getName() === 'str_split' && !$this->phpVersion->strSplitReturnsEmptyArray())
+			|| ($functionReflection->getName() === 'str_split' && !$this->phpVersion->strSplitReturnsEmptyArrayOnEmptyString())
 		) {
 			$returnType = TypeCombinator::intersect($returnType, new NonEmptyArrayType());
 		}