Tags to be in const

Author: janedbal

src/DependencyInjection/ConditionalTagsExtension.php

@@ -16,6 +16,12 @@
 use PHPStan\Parser\RichParser;
 use PHPStan\PhpDoc\StubFilesExtension;
 use PHPStan\PhpDoc\TypeNodeResolverExtension;
+use PHPStan\Reflection\Deprecation\ClassConstantDeprecationExtension;
+use PHPStan\Reflection\Deprecation\ClassDeprecationExtension;
+use PHPStan\Reflection\Deprecation\EnumCaseDeprecationExtension;
+use PHPStan\Reflection\Deprecation\FunctionDeprecationExtension;
+use PHPStan\Reflection\Deprecation\MethodDeprecationExtension;
+use PHPStan\Reflection\Deprecation\PropertyDeprecationExtension;
 use PHPStan\Rules\Constants\AlwaysUsedClassConstantsExtensionProvider;
 use PHPStan\Rules\LazyRegistry;
 use PHPStan\Rules\Properties\ReadWritePropertiesExtensionProvider;
@@ -61,6 +67,12 @@ public function getConfigSchema(): Nette\Schema\Schema
 			LazyParameterOutTypeExtensionProvider::STATIC_METHOD_TAG => $bool,
 			DiagnoseExtension::EXTENSION_TAG => $bool,
 			ResultCacheMetaExtension::EXTENSION_TAG => $bool,
+			ClassConstantDeprecationExtension::CLASS_CONSTANT_EXTENSION_TAG => $bool,
+			ClassDeprecationExtension::CLASS_EXTENSION_TAG => $bool,
+			EnumCaseDeprecationExtension::ENUM_CASE_EXTENSION_TAG => $bool,
+			FunctionDeprecationExtension::FUNCTION_EXTENSION_TAG => $bool,
+			MethodDeprecationExtension::METHOD_EXTENSION_TAG => $bool,
+			PropertyDeprecationExtension::PROPERTY_EXTENSION_TAG => $bool,
 		])->min(1));
 	}
 

src/Reflection/Deprecation/ClassConstantDeprecationExtension.php

@@ -22,6 +22,8 @@
 interface ClassConstantDeprecationExtension
 {
 
+	public const CLASS_CONSTANT_EXTENSION_TAG = 'phpstan.classConstantDeprecationExtension';
+
 	public function getClassConstantDeprecation(ReflectionClassConstant $reflection): ?Deprecation;
 
 }

src/Reflection/Deprecation/ClassDeprecationExtension.php

@@ -23,6 +23,8 @@
 interface ClassDeprecationExtension
 {
 
+	public const CLASS_EXTENSION_TAG = 'phpstan.classDeprecationExtension';
+
 	public function getClassDeprecation(ReflectionClass|ReflectionEnum $reflection): ?Deprecation;
 
 }

src/Reflection/Deprecation/ConstantDeprecationExtension.php

@@ -22,6 +22,8 @@
 interface ConstantDeprecationExtension
 {
 
+	public const CONSTANT_EXTENSION_TAG = 'phpstan.constantDeprecationExtension';
+
 	public function getConstantDeprecation(ReflectionConstant $reflection): ?Deprecation;
 
 }

src/Reflection/Deprecation/DeprecationProvider.php

@@ -45,7 +45,7 @@ public function __construct(
 
 	public function getPropertyDeprecation(ReflectionProperty $reflectionProperty): ?Deprecation
 	{
-		$this->propertyDeprecationExtensions ??= $this->container->getServicesByTag('phpstan.propertyDeprecationExtension');
+		$this->propertyDeprecationExtensions ??= $this->container->getServicesByTag(PropertyDeprecationExtension::PROPERTY_EXTENSION_TAG);
 
 		foreach ($this->propertyDeprecationExtensions as $extension) {
 			$deprecation = $extension->getPropertyDeprecation($reflectionProperty);
@@ -59,7 +59,7 @@ public function getPropertyDeprecation(ReflectionProperty $reflectionProperty):
 
 	public function getMethodDeprecation(ReflectionMethod $methodReflection): ?Deprecation
 	{
-		$this->methodDeprecationExtensions ??= $this->container->getServicesByTag('phpstan.methodDeprecationExtension');
+		$this->methodDeprecationExtensions ??= $this->container->getServicesByTag(MethodDeprecationExtension::METHOD_EXTENSION_TAG);
 
 		foreach ($this->methodDeprecationExtensions as $extension) {
 			$deprecation = $extension->getMethodDeprecation($methodReflection);
@@ -73,7 +73,7 @@ public function getMethodDeprecation(ReflectionMethod $methodReflection): ?Depre
 
 	public function getClassConstantDeprecation(ReflectionClassConstant $reflectionConstant): ?Deprecation
 	{
-		$this->classConstantDeprecationExtensions ??= $this->container->getServicesByTag('phpstan.classConstantDeprecationExtension');
+		$this->classConstantDeprecationExtensions ??= $this->container->getServicesByTag(ClassConstantDeprecationExtension::CLASS_CONSTANT_EXTENSION_TAG);
 
 		foreach ($this->classConstantDeprecationExtensions as $extension) {
 			$deprecation = $extension->getClassConstantDeprecation($reflectionConstant);
@@ -87,7 +87,7 @@ public function getClassConstantDeprecation(ReflectionClassConstant $reflectionC
 
 	public function getClassDeprecation(ReflectionClass|ReflectionEnum $reflection): ?Deprecation
 	{
-		$this->classDeprecationExtensions ??= $this->container->getServicesByTag('phpstan.classDeprecationExtension');
+		$this->classDeprecationExtensions ??= $this->container->getServicesByTag(ClassDeprecationExtension::CLASS_EXTENSION_TAG);
 
 		foreach ($this->classDeprecationExtensions as $extension) {
 			$deprecation = $extension->getClassDeprecation($reflection);
@@ -101,7 +101,7 @@ public function getClassDeprecation(ReflectionClass|ReflectionEnum $reflection):
 
 	public function getFunctionDeprecation(ReflectionFunction $reflectionFunction): ?Deprecation
 	{
-		$this->functionDeprecationExtensions ??= $this->container->getServicesByTag('phpstan.functionDeprecationExtension');
+		$this->functionDeprecationExtensions ??= $this->container->getServicesByTag(FunctionDeprecationExtension::FUNCTION_EXTENSION_TAG);
 
 		foreach ($this->functionDeprecationExtensions as $extension) {
 			$deprecation = $extension->getFunctionDeprecation($reflectionFunction);
@@ -115,7 +115,7 @@ public function getFunctionDeprecation(ReflectionFunction $reflectionFunction):
 
 	public function getConstantDeprecation(ReflectionConstant $constantReflection): ?Deprecation
 	{
-		$this->constantDeprecationExtensions ??= $this->container->getServicesByTag('phpstan.constantDeprecationExtension');
+		$this->constantDeprecationExtensions ??= $this->container->getServicesByTag(ConstantDeprecationExtension::CONSTANT_EXTENSION_TAG);
 
 		foreach ($this->constantDeprecationExtensions as $extension) {
 			$deprecation = $extension->getConstantDeprecation($constantReflection);
@@ -129,7 +129,7 @@ public function getConstantDeprecation(ReflectionConstant $constantReflection):
 
 	public function getEnumCaseDeprecation(ReflectionEnumUnitCase|ReflectionEnumBackedCase $enumCaseReflection): ?Deprecation
 	{
-		$this->enumCaseDeprecationExtensions ??= $this->container->getServicesByTag('phpstan.enumCaseDeprecationExtension');
+		$this->enumCaseDeprecationExtensions ??= $this->container->getServicesByTag(EnumCaseDeprecationExtension::ENUM_CASE_EXTENSION_TAG);
 
 		foreach ($this->enumCaseDeprecationExtensions as $extension) {
 			$deprecation = $extension->getEnumCaseDeprecation($enumCaseReflection);

src/Reflection/Deprecation/EnumCaseDeprecationExtension.php

@@ -23,6 +23,8 @@
 interface EnumCaseDeprecationExtension
 {
 
+	public const ENUM_CASE_EXTENSION_TAG = 'phpstan.enumCaseDeprecationExtension';
+
 	public function getEnumCaseDeprecation(ReflectionEnumUnitCase|ReflectionEnumBackedCase $reflection): ?Deprecation;
 
 }

src/Reflection/Deprecation/FunctionDeprecationExtension.php

@@ -22,6 +22,8 @@
 interface FunctionDeprecationExtension
 {
 
+	public const FUNCTION_EXTENSION_TAG = 'phpstan.functionDeprecationExtension';
+
 	public function getFunctionDeprecation(ReflectionFunction $reflection): ?Deprecation;
 
 }

src/Reflection/Deprecation/MethodDeprecationExtension.php

@@ -22,6 +22,8 @@
 interface MethodDeprecationExtension
 {
 
+	public const METHOD_EXTENSION_TAG = 'phpstan.methodDeprecationExtension';
+
 	public function getMethodDeprecation(ReflectionMethod $reflection): ?Deprecation;
 
 }

src/Reflection/Deprecation/PropertyDeprecationExtension.php

@@ -22,6 +22,8 @@
 interface PropertyDeprecationExtension
 {
 
+	public const PROPERTY_EXTENSION_TAG = 'phpstan.propertyDeprecationExtension';
+
 	public function getPropertyDeprecation(ReflectionProperty $reflection): ?Deprecation;
 
 }