Fix duplicate work in AnnotationsPropertiesClassReflectionExtension->findClassReflectionWithProperty()

staabm · staabm · commit ec6016101763 · 2025-08-29T10:54:23.000+02:00
diff --git a/src/Reflection/Annotations/AnnotationsPropertiesClassReflectionExtension.php b/src/Reflection/Annotations/AnnotationsPropertiesClassReflectionExtension.php
@@ -81,13 +81,11 @@ private function findClassReflectionWithProperty(
 		}
 
 		$parentClass = $classReflection->getParentClass();
-		while ($parentClass !== null) {
+		if ($parentClass !== null) {
 			$methodWithDeclaringClass = $this->findClassReflectionWithProperty($parentClass, $parentClass, $propertyName);
 			if ($methodWithDeclaringClass !== null) {
 				return $methodWithDeclaringClass;
 			}
-
-			$parentClass = $parentClass->getParentClass();
 		}
 
 		foreach ($classReflection->getInterfaces() as $interfaceClass) {

Original file line number	Diff line number	Diff line change
`@@ -81,13 +81,11 @@ private function findClassReflectionWithProperty(`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`$parentClass = $classReflection->getParentClass();`
`84`		`- while ($parentClass !== null) {`
	`84`	`+ if ($parentClass !== null) {`
`85`	`85`	`$methodWithDeclaringClass = $this->findClassReflectionWithProperty($parentClass, $parentClass, $propertyName);`
`86`	`86`	`if ($methodWithDeclaringClass !== null) {`
`87`	`87`	`return $methodWithDeclaringClass;`
`88`	`88`	`}`
`89`		`-`
`90`		`- $parentClass = $parentClass->getParentClass();`
`91`	`89`	`}`
`92`	`90`
`93`	`91`	`foreach ($classReflection->getInterfaces() as $interfaceClass) {`