fixes

Author: DanielEScherzer

Makefile

@@ -111,7 +111,7 @@ lint:
 		--exclude tests/PHPStan/Rules/Classes/data/class-attributes.php \
 		--exclude tests/PHPStan/Rules/Classes/data/enum-attributes.php \
 		--exclude tests/PHPStan/Rules/Cast/data/void-cast.php \
-		--exclude tests/PHPStan/Rules/Properties/data/property-hook-attributes.php \
+		--exclude tests/PHPStan/Rules/Properties/data/property-hook-attributes-nodiscard.php \
 		src tests
 
 install-paratest:

build/collision-detector.json

@@ -19,6 +19,7 @@
 		"../tests/PHPStan/Rules/Functions/data/function-call-statement-result-discarded.php",
 		"../tests/PHPStan/Rules/Methods/data/method-call-statement-result-discarded.php",
 		"../tests/PHPStan/Rules/Methods/data/static-method-call-statement-result-discarded.php",
-		"../tests/PHPStan/Rules/Properties/data/property-hook-attributes.php"
+		"../tests/PHPStan/Rules/Properties/data/property-hook-attributes-nodiscard.php",
+		"../tests/PHPStan/Rules/Cast/data/void-cast.php"
     ]
 }

src/Rules/AttributesCheck.php

@@ -82,7 +82,7 @@ public function check(
 						->identifier('attribute.target')
 						->line($attribute->getStartLine())
 						->build();
-				} elseif ($isPropertyHook && strtolower($name) === "nodiscard") {
+				} elseif ($isPropertyHook && strtolower($name) === 'nodiscard') {
 					// #[\NoDiscard] cannot be used on property hooks
 					$errors[] = RuleErrorBuilder::message(sprintf('Attribute class %s cannot be used on property hooks.', $name))
 						->identifier('attribute.target')

tests/PHPStan/Rules/Properties/PropertyHookAttributesRuleTest.php

@@ -55,9 +55,16 @@ public function testRule(): void
 				'Attribute class PropertyHookAttributes\Foo does not have the method target.',
 				27,
 			],
+		]);
+	}
+
+	#[RequiresPhp('>= 8.5')]
+	public function testNoDiscard(): void
+	{
+		$this->analyse([__DIR__ . '/data/property-hook-attributes-nodiscard.php'], [
 			[
 				'Attribute class NoDiscard cannot be used on property hooks.',
-				63,
+				9,
 			],
 		]);
 	}

tests/PHPStan/Rules/Properties/data/property-hook-attributes-nodiscard.php

@@ -0,0 +1,14 @@
+<?php // lint >= 8.5
+
+namespace PropertyHookAttributes;
+
+class Sit
+{
+
+	public int $i {
+		#[\NoDiscard]
+		get {
+
+		}
+	}
+}

tests/PHPStan/Rules/Properties/data/property-hook-attributes.php

@@ -55,14 +55,3 @@ class Dolor
 	}
 
 }
-
-class Sit
-{
-
-	public int $i {
-		#[\NoDiscard]
-		get {
-
-		}
-	}
-}