From ba31578dbe57bacb13813ec088dfb6df94e7c82d Mon Sep 17 00:00:00 2001
From: Can Vural <can9119@gmail.com>
Date: Mon, 11 Nov 2024 10:15:15 +0100
Subject: [PATCH] fix: check for existence of second arg in
 CountCharsFunctionDynamicReturnTypeExtension

---
 .../Php/CountCharsFunctionDynamicReturnTypeExtension.php   | 7 +++++--
 tests/PHPStan/Analyser/nsrt/count-chars-7.4.php            | 1 +
 tests/PHPStan/Analyser/nsrt/count-chars-8.0.php            | 1 +
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/Type/Php/CountCharsFunctionDynamicReturnTypeExtension.php b/src/Type/Php/CountCharsFunctionDynamicReturnTypeExtension.php
index cddb7e7989..e798af6bbd 100644
--- a/src/Type/Php/CountCharsFunctionDynamicReturnTypeExtension.php
+++ b/src/Type/Php/CountCharsFunctionDynamicReturnTypeExtension.php
@@ -8,6 +8,7 @@
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\Constant\ConstantBooleanType;
+use PHPStan\Type\Constant\ConstantIntegerType;
 use PHPStan\Type\DynamicFunctionReturnTypeExtension;
 use PHPStan\Type\IntegerRangeType;
 use PHPStan\Type\IntegerType;
@@ -35,11 +36,13 @@ public function getTypeFromFunctionCall(
 		Scope $scope,
 	): ?Type
 	{
-		if (count($functionCall->getArgs()) < 1) {
+		$args = $functionCall->getArgs();
+
+		if (count($args) < 1) {
 			return null;
 		}
 
-		$modeType = $scope->getType($functionCall->getArgs()[1]->value);
+		$modeType = count($args) === 2 ? $scope->getType($args[1]->value) : new ConstantIntegerType(0);
 
 		if (IntegerRangeType::fromInterval(0, 2)->isSuperTypeOf($modeType)->yes()) {
 			$arrayType = new ArrayType(new IntegerType(), new IntegerType());
diff --git a/tests/PHPStan/Analyser/nsrt/count-chars-7.4.php b/tests/PHPStan/Analyser/nsrt/count-chars-7.4.php
index 713d73a5e1..76e0bea581 100644
--- a/tests/PHPStan/Analyser/nsrt/count-chars-7.4.php
+++ b/tests/PHPStan/Analyser/nsrt/count-chars-7.4.php
@@ -8,6 +8,7 @@ class X {
 	const ABC = 'abcdef';
 
 	function doFoo(): void {
+		assertType('array<int, int>|false', count_chars(self::ABC));
 		assertType('array<int, int>|false', count_chars(self::ABC, 0));
 		assertType('array<int, int>|false', count_chars(self::ABC, 1));
 		assertType('array<int, int>|false', count_chars(self::ABC, 2));
diff --git a/tests/PHPStan/Analyser/nsrt/count-chars-8.0.php b/tests/PHPStan/Analyser/nsrt/count-chars-8.0.php
index 88a165e931..6e0af08f03 100644
--- a/tests/PHPStan/Analyser/nsrt/count-chars-8.0.php
+++ b/tests/PHPStan/Analyser/nsrt/count-chars-8.0.php
@@ -8,6 +8,7 @@ class Y {
 	const ABC = 'abcdef';
 
 	function doFoo(): void {
+		assertType('array<int, int>', count_chars(self::ABC));
 		assertType('array<int, int>', count_chars(self::ABC, 0));
 		assertType('array<int, int>', count_chars(self::ABC, 1));
 		assertType('array<int, int>', count_chars(self::ABC, 2));