Enforce more things in pid files:

 * layout is present and "pid"
 * title, license are present

Fix errors in several existing PID files.

Also change the output format so that the affected files can be
automatically visited by vim when the output of validate_pids is used
as the error file.

Author: jepler

1209/2019/index.md

@@ -1,5 +1,5 @@
 ---
-layout: 2019
+layout: pid
 title: PunchBOOT
 owner: jop
 license: BSD-3

1209/DE5C/index.md

@@ -1,5 +1,6 @@
 ---
 layout: pid
+title: "Desk Viking"
 owner: earth.li
 license: GPLv3
 site: https://github.com/u1f35c/desk-viking

test/validate_pids.py

@@ -7,6 +7,8 @@
                  '0005', '0070', '0D32'}
 existing_1xxx = {'1AB6', '1005', '1776', '1001', '1007', '1AB5', '1002', '1006', '1004', '1003', '1986'}
 
+required_keys = ['title', 'license']
+
 vid_1209 = Path("1209")
 pid1xxx = vid_1209.glob("1*")
 pid1xxx = set([x.name for x in pid1xxx])
@@ -44,18 +46,27 @@
         print("Pid is too long: '" + pid + "'")
 
     try:
-        post = frontmatter.load(vid_1209 / pid / "index.md")
+        pid_path = vid_1209 / pid / "index.md"
+        post = frontmatter.load(pid_path)
+        layout = post.get('layout')
+        if layout != "pid":
+            print(f"{pid_path}:0: Layout must be 'pid'")
+            ok = False
         owner = post.get('owner')
         if owner is None:
-            print(f"No owner specified for {pid} @ {vid_1209 / pid / 'index.md'}")
+            print(f"{pid_path}:0: No owner specified")
             ok = False
             continue
         owner_path = Path("org") / owner / "index.md"
         if not owner_path.exists():
-            print(f"Owner file {owner} for pid {pid} does not exist")
+            print(f"{pid_path}:0: Owner file {owner} does not exist")
             ok = False
+        for k in required_keys:
+            if k not in post.metadata:
+                print(f"{pid_path}:0: Required key {k} not present in front matter")
+                ok = False
     except Exception as e:
-        print(f"Failure parsing front matter for {pid}: {e}")
+        print(f"{pid_path}: Failure parsing front matter: {e}")
         ok = False
 if pid1xxx - existing_1xxx:
     print("Cannot claim 1xxx PID:", pid1xxx - existing_1xxx)