Commit 117d727
authored
Upgrade pxapi pypi python dependencies. Replace
Summary: Upgrade pxapi pypi python dependencies. Replace rules_go gogo
with `third_party` dir version
This change is best viewed commit by commit as described below.
Commit 1: Replace `rules_go`'s version of gogo with third_party
directory copy
Commit 2: Update proto and BUILD files to use new bazel repo name
Commit 3: Regnerate go and ts/js protos. TS/JS ones are expected to not
change
Commit 4: Replace python pxapi's python-gogo with the bazel version.
The existing gogo bazel repository needed to be changed because Python
does not support periods in module names. `rules_go` and our internal
gogo repository (`gogo_grpc_proto`) used a directory structure and a
protobuf compiler patch that resulting in non functional python code (a
module named `github.com` is created). This change renames the internal
gogo repository to prevent its filepath from containing periods.
The pr-third-party-deps action is complaining about protobuf. I believe
this is a false positive as it uses the BSD-3-Clause license.
Relevant Issues: #2140
Type of change: /kind cleanup
Test Plan: Existing unit tests and the following:
- [x] Ran `src/api/python/examples` with python 3.9 and 3.13
<details><summary>Python 3.9 and 3.13 test</summary>
```
# Build the wheel
$ bazel build src/api/python:pxapi
[ ... ]
Target //src/api/python:pxapi up-to-date:
bazel-bin/src/api/python/pxapi-0.8.1-py3-none-any.whl
# Run the example with python 3.13
$ docker run --entrypoint bash -it -v $(pwd):/src -w /src python:3.13
$ pip install bazel-bin/src/api/python/pxapi-0.8.1-py3-none-any.whl
root@d5a1f69d4e87:/src# PX_API_KEY=<api key> python src/api/python/examples/list_clusters.py
eb94bd7e-0a8a-45c0-b22e-81d62bd99755
# Run the example with python 3.9
$ docker run --entrypoint bash -it -v $(pwd):/src -w /src python:3.9
$ pip install bazel-bin/src/api/python/pxapi-0.8.1-py3-none-any.whl
root@08ed22fe680e:/src# PX_API_KEY=<api key> python src/api/python/examples/list_clusters.py
eb94bd7e-0a8a-45c0-b22e-81d62bd99755
```
</details>
Changelog Message: Upgrade the pxapi python module's third party
dependencies and support Python 3.11 through 3.13
---------
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>rules_go's gogo with third_party dir version (#2181)1 parent 2711c9f commit 117d727
File tree
121 files changed
+3336
-3334
lines changed- bazel
- external
- scripts
- src
- api
- proto
- cloudpb
- vispb
- vizierconfigpb
- vizierpb
- python
- pxapi
- proto
- carnot
- carnotpb
- docspb
- planner
- compilerpb
- distributedpb
- dynamic_tracing/ir/logicalpb
- plannerpb
- planpb
- queryresultspb
- udfspb
- cloud
- artifact_tracker/artifacttrackerpb
- auth/authpb
- config_manager/configmanagerpb
- cron_script/cronscriptpb
- plugin/pluginpb
- profile/profilepb
- project_manager/projectmanagerpb
- scriptmgr/scriptmgrpb
- vzconn/vzconnpb
- vzmgr/vzmgrpb
- e2e_test
- perf_tool/experimentpb
- protocol_loadtest/grpc/loadtestpb
- stirling
- proto
- source_connectors/dynamic_tracer/dynamic_tracing/ir/logicalpb
- testing/demo_apps/go_grpc_tls_pl/server/greetpb
- table_store/schemapb
- vizier
- messages/messagespb
- services
- metadata
- metadatapb
- storepb
- third_party/gogoproto
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
121 files changed
+3336
-3334
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
| 26 | + | |
| 27 | + | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
47 | 54 | | |
48 | 55 | | |
49 | 56 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
| 124 | + | |
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments