Skip to content

Commit 80acc6b

Browse files
authored
[chore] upgrade canvas (#1392)
Summary: The version of canvas we depended on didn't have pre-built binaries for node v18 and node-gyp was failing during the build step on some machines. This upgrades canvas to a version that publishes pre-built binaries for node v18 and fixes the issue. Type of change: /kind devinfra Test Plan: `yarn install` doesn't call node-gyp for canvas and succeeds. Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
1 parent ed37acb commit 80acc6b

File tree

2 files changed

+12
-19
lines changed

2 files changed

+12
-19
lines changed

src/ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"@yarnpkg/pnpify": "^3.1.0",
3434
"archiver": "^5.0.2",
3535
"babel-jest": "^27.3.1",
36-
"canvas": "^2.8.0",
36+
"canvas": "^2.11.2",
3737
"case-sensitive-paths-webpack-plugin": "^2.1.2",
3838
"compression-webpack-plugin": "^4.0.0",
3939
"concurrently": "^6.2.0",

src/ui/yarn.lock

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2300,7 +2300,7 @@ __metadata:
23002300
assets: "link:./assets"
23012301
axios: ^0.21.4
23022302
babel-jest: ^27.3.1
2303-
canvas: ^2.8.0
2303+
canvas: ^2.11.2
23042304
case-sensitive-paths-webpack-plugin: ^2.1.2
23052305
compression-webpack-plugin: ^4.0.0
23062306
concurrently: ^6.2.0
@@ -4677,15 +4677,15 @@ __metadata:
46774677
languageName: node
46784678
linkType: hard
46794679

4680-
"canvas@npm:^2.8.0":
4681-
version: 2.8.0
4682-
resolution: "canvas@npm:2.8.0"
4680+
"canvas@npm:^2.11.2":
4681+
version: 2.11.2
4682+
resolution: "canvas@npm:2.11.2"
46834683
dependencies:
46844684
"@mapbox/node-pre-gyp": ^1.0.0
4685-
nan: ^2.14.0
4685+
nan: ^2.17.0
46864686
node-gyp: latest
46874687
simple-get: ^3.0.3
4688-
checksum: 4cc909f63eaf88d22f9164601903745abcc6ccb7f70090b9389dc2cb68cbf139c220dbd75837e6d04602ff122b44a2eb17413bca850f9c6c602f74f1f0f1cc3f
4688+
checksum: 61e554aef80022841dc836964534082ec21435928498032562089dfb7736215f039c7d99ee546b0cf10780232d9bf310950f8b4d489dc394e0fb6f6adfc97994
46894689
languageName: node
46904690
linkType: hard
46914691

@@ -10741,12 +10741,12 @@ __metadata:
1074110741
languageName: node
1074210742
linkType: hard
1074310743

10744-
"nan@npm:^2.14.0":
10745-
version: 2.15.0
10746-
resolution: "nan@npm:2.15.0"
10744+
"nan@npm:^2.17.0":
10745+
version: 2.17.0
10746+
resolution: "nan@npm:2.17.0"
1074710747
dependencies:
1074810748
node-gyp: latest
10749-
checksum: 33e1bb4dfca447fe37d4bb5889be55de154828632c8d38646db67293a21afd61ed9909cdf1b886214a64707d935926c4e60e2b09de9edfc2ad58de31d6ce8f39
10749+
checksum: ec609aeaf7e68b76592a3ba96b372aa7f5df5b056c1e37410b0f1deefbab5a57a922061e2c5b369bae9c7c6b5e6eecf4ad2dac8833a1a7d3a751e0a7c7f849ed
1075010750
languageName: node
1075110751
linkType: hard
1075210752

@@ -14206,14 +14206,7 @@ resolve@^2.0.0-next.3:
1420614206
languageName: node
1420714207
linkType: hard
1420814208

14209-
"tslib@npm:^2.0.3, tslib@npm:^2.1.0, tslib@npm:^2.3.0":
14210-
version: 2.3.1
14211-
resolution: "tslib@npm:2.3.1"
14212-
checksum: de17a98d4614481f7fcb5cd53ffc1aaf8654313be0291e1bfaee4b4bb31a20494b7d218ff2e15017883e8ea9626599b3b0e0229c18383ba9dce89da2adf15cb9
14213-
languageName: node
14214-
linkType: hard
14215-
14216-
"tslib@npm:~2.5.0":
14209+
"tslib@npm:^2.0.3, tslib@npm:^2.1.0, tslib@npm:^2.3.0, tslib@npm:~2.5.0":
1421714210
version: 2.5.0
1421814211
resolution: "tslib@npm:2.5.0"
1421914212
checksum: ae3ed5f9ce29932d049908ebfdf21b3a003a85653a9a140d614da6b767a93ef94f460e52c3d787f0e4f383546981713f165037dc2274df212ea9f8a4541004e1

0 commit comments

Comments
 (0)