Fix script bundle creation and improve PEM/Kelvin heap dump collection for large clusters (#2247)

Author: ddelnano

src/pxl_scripts/px/collect_heap_dumps.pxl …lect_agent_heaps/collect_agent_heaps.pxlsrc/pxl_scripts/px/collect_heap_dumps.pxl renamed to src/pxl_scripts/px/collect_agent_heaps/collect_agent_heaps.pxl src/pxl_scripts/px/collect_heap_dumps.pxl renamed to src/pxl_scripts/px/collect_agent_heaps/collect_agent_heaps.pxl

@@ -16,13 +16,15 @@
 
 import px
 
-df = px.GetAgentStatus()
-df.ip_address = px.pluck_array(px.split(df.ip_address, ":"), 0)
-df.hostname_by_ip = px.pod_id_to_node_name(px.ip_to_pod_id(df.ip_address))
-df.hostname = px.select(df.hostname_by_ip == "", df.hostname, df.hostname_by_ip)
-df = df[['asid', 'hostname']]
-heap_stats = px._HeapGrowthStacks()
-df = df.merge(heap_stats, how='inner', left_on='asid', right_on='asid')
-df.asid = df.asid_x
-df = df[['asid', 'hostname', 'heap']]
-px.display(df)
+
+# TODO(ddelnano): asid is unused until gh#2245 is addressed.
+def collect_pprofs(asid: int):
+    df = px.GetAgentStatus()
+    df.ip_address = px.pluck_array(px.split(df.ip_address, ":"), 0)
+    df.hostname_by_ip = px.pod_id_to_node_name(px.ip_to_pod_id(df.ip_address))
+    df.hostname = px.select(df.hostname_by_ip == "", df.hostname, df.hostname_by_ip)
+    df = df[['asid', 'hostname']]
+    heap_stats = px._HeapGrowthStacks()
+    df = df.merge(heap_stats, how='inner', left_on='asid', right_on='asid')
+    df.asid = df.asid_x
+    return df[['asid', 'hostname', 'heap']]

src/pxl_scripts/px/collect_agent_heaps/manifest.yaml

@@ -0,0 +1,3 @@
+---
+short: Collect Agent Heap Dumps
+long: Script useful for debugging kelvin and PEM memory footprint.

src/pxl_scripts/px/collect_agent_heaps/vis.json

@@ -0,0 +1,39 @@
+{
+    "variables": [
+        {
+            "name": "asid",
+            "type": "PX_INT64",
+            "description": "Whether to filter the results to a particular ASID",
+            "defaultValue": "-1"
+        }
+    ],
+    "globalFuncs": [
+        {
+            "outputName": "collect_pprofs",
+            "func": {
+                "name": "collect_pprofs",
+                "args": [
+                    {
+                        "name": "asid",
+                        "variable": "asid"
+                    }
+                ]
+            }
+        }
+    ],
+    "widgets": [
+        {
+            "name": "Table",
+            "position": {
+                "x": 0,
+                "y": 0,
+                "w": 12,
+                "h": 4
+            },
+            "globalFuncOutputName": "collect_pprofs",
+            "displaySpec": {
+                "@type": "types.px.dev/px.vispb.Table"
+            }
+        }
+    ]
+}