Replace rules_meta with with_cfg.bzl

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

Author: ddelnano

.bazelrc

@@ -22,11 +22,6 @@ run --remote_download_outputs=all
 coverage --build_runfile_links
 coverage --nocache_test_results
 
-# Needed by rules_meta.
-# Follow https://github.com/fmeum/rules_meta/issues/1#issuecomment-1255828109
-# for updates.
-common --incompatible_remove_rule_name_parameter=false
-
 # Get version information into the build.
 build --workspace_status_command=bazel/get_workspace_status.sh
 

WORKSPACE

@@ -19,6 +19,10 @@ pl_register_cc_toolchains()
 # Install Pixie Labs Dependencies.
 pl_deps()
 
+load("@bazel_features//:deps.bzl", "bazel_features_deps")
+
+bazel_features_deps()
+
 # Order is important. Try to go from most basic/primitive to higher level packages.
 # - go_rules_dependencies
 # - protobuf_deps

bazel/repositories.bzl

@@ -257,8 +257,9 @@ def _pl_deps():
     _bazel_repo("rules_python")
     _bazel_repo("rules_pkg")
     _bazel_repo("com_github_bazelbuild_buildtools")
-    _bazel_repo("com_github_fmeum_rules_meta")
     _bazel_repo("com_google_protobuf_javascript", patches = ["//bazel/external:protobuf_javascript.patch"], patch_args = ["-p1"])
+    _bazel_repo("bazel_features")
+    _bazel_repo("with_cfg.bzl")
 
     _com_llvm_lib()
     _cc_deps()

bazel/repository_locations.bzl

@@ -15,6 +15,11 @@
 # SPDX-License-Identifier: Apache-2.0
 
 REPOSITORY_LOCATIONS = dict(
+    bazel_features = dict(
+        sha256 = "07271d0f6b12633777b69020c4cb1eb67b1939c0cf84bb3944dc85cc250c0c01",
+        strip_prefix = "bazel_features-1.38.0",
+        urls = ["https://github.com/bazel-contrib/bazel_features/releases/download/v1.38.0/bazel_features-v1.38.0.tar.gz"],
+    ),
     bazel_gazelle = dict(
         sha256 = "d76bf7a60fd8b050444090dfa2837a4eaf9829e1165618ee35dceca5cbdf58d5",
         urls = [
@@ -81,13 +86,6 @@ REPOSITORY_LOCATIONS = dict(
         strip_prefix = "tdigest-85e0f70092460e60236821db4c25143768d3da12",
         urls = ["https://github.com/pixie-io/tdigest/archive/85e0f70092460e60236821db4c25143768d3da12.tar.gz"],
     ),
-    com_github_fmeum_rules_meta = dict(
-        sha256 = "ed3ed909e6e3f34a11d7c2adcc461535975a875fe434719540a4e6f63434a866",
-        strip_prefix = "rules_meta-0.0.4",
-        urls = [
-            "https://github.com/fmeum/rules_meta/archive/refs/tags/v0.0.4.tar.gz",
-        ],
-    ),
     com_github_gflags_gflags = dict(
         sha256 = "9e1a38e2dcbb20bb10891b5a171de2e5da70e0a50fff34dd4b0c2c6d75043909",
         strip_prefix = "gflags-524b83d0264cb9f1b2d134c564ef1aa23f207a41",
@@ -505,6 +503,12 @@ REPOSITORY_LOCATIONS = dict(
     ),
 )
 
+REPOSITORY_LOCATIONS["with_cfg.bzl"] = dict(
+    sha256 = "c7af6227d24499438fa0bb96fe4034e163d8c807b06f7c0645f3654448268b84",
+    strip_prefix = "with_cfg.bzl-0.11.0",
+    urls = ["https://github.com/fmeum/with_cfg.bzl/releases/download/v0.11.0/with_cfg.bzl-v0.11.0.tar.gz"],
+)
+
 # To modify one of the forked repos below:
 #  1. Make the changes to the repo and push the changes to the `pixie` on github.
 #  2. Update the commit below to point to the commit hash of the new `pixie` branch.

bazel/toolchain_transitions.bzl

@@ -14,30 +14,15 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-load("@com_github_fmeum_rules_meta//meta:defs.bzl", "meta")
+load("@with_cfg.bzl", "with_cfg")
 load("//bazel/test_runners/qemu_with_kernel:runner.bzl", "qemu_with_kernel_interactive_runner")
 
-java_graal_binary = meta.wrap_with_transition(
-    native.java_binary,
-    {
-        "java_runtime_version": meta.replace_with("remotejdk_openjdk_graal_17"),
-    },
-    executable = True,
-)
+java_graal_binary, _java_graal_binary_internal = with_cfg(native.java_binary).set(
+    "java_runtime_version", "remotejdk_openjdk_graal_17").build()
 
-cc_clang_binary = meta.wrap_with_transition(
-    native.cc_binary,
-    {
-        "@//bazel/cc_toolchains:compiler": meta.replace_with("clang"),
-        "@//bazel/cc_toolchains:libc_version": meta.replace_with("glibc2_36"),
-    },
-    executable = True,
-)
+cc_clang_binary, _cc_clang_binary_internal = with_cfg(native.cc_binary).set(
+        Label("@//bazel/cc_toolchains:compiler"), "clang").set(
+        Label("@//bazel/cc_toolchains:libc_version"), "glibc2_36").build()
 
-qemu_interactive_runner = meta.wrap_with_transition(
-    qemu_with_kernel_interactive_runner,
-    {
-        "@//bazel/cc_toolchains:libc_version": meta.replace_with("glibc2_36"),
-    },
-    executable = True,
-)
+qemu_interactive_runner, _qemu_interactive_runner_internal = with_cfg(qemu_with_kernel_interactive_runner).set(
+    Label("@//bazel/cc_toolchains:libc_version"), "glibc2_36").build()