Skip to content

Commit f4e30ef

Browse files
authored
Increase ASAN short test timeout to address flaky tests (#2294)
Summary: Increase ASAN short test timeout to address flaky tests The following tests are frequently hitting the 2-minute Bazel timeout on ASAN builds: - `//src/vizier/services/agent/shared/manager:heartbeat_test` - `//src/vizier/services/agent/shared/manager:registration_test` - `//src/carnot/builtins:collections_test` BuildBuddy history from the main branch shows these tests are running up against the timeout threshold (see screenshot below). I believe BuildBuddy is under reporting the issues seen since builds are also seeing BEP API timeouts. <img width="912" height="512" alt="Screenshot 2025-12-10 at 12 05 55 PM" src="https://github.com/user-attachments/assets/3a7632b9-ef1d-407b-81aa-1f9babdbaea3" /> ``` //src/vizier/services/agent/shared/manager:heartbeat_test TIMEOUT in 120.5s /github/home/.cache/bazel/_bazel_root/56ec069a32c4abebc78228236a835895/execroot/px/bazel-out/k8-dbg/testlogs/src/vizier/services/agent/shared/manager/heartbeat_test/test.log //src/vizier/services/agent/shared/manager:registration_test TIMEOUT in 120.5s /github/home/.cache/bazel/_bazel_root/56ec069a32c4abebc78228236a835895/execroot/px/bazel-out/k8-dbg/testlogs/src/vizier/services/agent/shared/manager/registration_test/test.log [ ... ] ERROR: The Build Event Protocol upload timed out. com.google.common.util.concurrent.TimeoutFuture$TimeoutFutureException: Timed out: NonCancellationPropagatingFuture@6ce6bba6[status=PENDING, info=[delegate=[SettableFuture@29e4285e[status=PENDING]]]] Bazel returned code 38, ignoring... ``` This PR increases the short test timeout to unblock ongoing Bazel 7 upgrade work and prevent unrelated PRs from failing due to these timeouts. Relevant Issues: #2295 Type of change: /kind bugfix Test Plan: Build succeeds --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
1 parent b81253e commit f4e30ef

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.bazelrc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,8 @@ test:gcc --config=tmp-sandbox
143143
build:asan --config=clang
144144
build:asan --//bazel:sanitizer=asan
145145
build:asan --features=asan
146-
build:asan --test_timeout="120,600,1800,3600"
146+
# TODO(#2295): Revert to lower timeouts once ASAN performance is improved.
147+
build:asan --test_timeout="180,600,1800,3600"
147148
build:asan --define PL_CONFIG_ASAN=1
148149
build:asan --define tcmalloc=disabled
149150
build:asan --build_tag_filters=-no_asan

0 commit comments

Comments
 (0)