Commit ff7906e
authored
Refine
Summary: We are working on adding the px-k8ssandra demo in our demo
apps. However, this demo app is more complex. It requires cluster-scoped
resources such as mutating webhooks, and proper cleanup requires the
K8ssandraCluster to be deleted first or else things will hang.
We can control the delete process through labels. Adding labels to the
demo resources allow us to target cluster-scoped resources that wouldn't
be deleted from just deleting the namespace. We can use an additional
label for resources that need to be cleaned up first.
Relevant Issues: #680
Type of change: /kind cleanup
Test Plan: Deploy px-k8ssandra demo app and delete. Make sure resources
all get cleaned up and delete runs without error. Also make sure delete
still works on existing demo-apps, such as px-sock-shop.
Changelog Message:
```release-note
Enhanced `px demo` to support more complex applications which require CRDs
```
Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>px demo delete logic for more complex demo applications (#1376)1 parent fa4b452 commit ff7906e
File tree
3 files changed
+158
-1
lines changed- demos
- k8ssandra
- src/pixie_cli/pkg/cmd
3 files changed
+158
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
73 | 76 | | |
74 | 77 | | |
75 | 78 | | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
76 | 82 | | |
77 | 83 | | |
78 | 84 | | |
| |||
0 commit comments