Skip to content

Commit ff7906e

Browse files
authored
Refine px demo delete logic for more complex demo applications (#1376)
Summary: We are working on adding the px-k8ssandra demo in our demo apps. However, this demo app is more complex. It requires cluster-scoped resources such as mutating webhooks, and proper cleanup requires the K8ssandraCluster to be deleted first or else things will hang. We can control the delete process through labels. Adding labels to the demo resources allow us to target cluster-scoped resources that wouldn't be deleted from just deleting the namespace. We can use an additional label for resources that need to be cleaned up first. Relevant Issues: #680 Type of change: /kind cleanup Test Plan: Deploy px-k8ssandra demo app and delete. Make sure resources all get cleaned up and delete runs without error. Also make sure delete still works on existing demo-apps, such as px-sock-shop. Changelog Message: ```release-note Enhanced `px demo` to support more complex applications which require CRDs ``` Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
1 parent fa4b452 commit ff7906e

File tree

3 files changed

+158
-1
lines changed

3 files changed

+158
-1
lines changed

demos/README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,15 @@ file describes the demo scenarios.
7070
# Your kustomize version must be v4.5.7 or newer for these configs
7171
7272
k8ssandra-operator-root-dir $ cd config/crd
73+
# Edit config/crd/kustomization.yaml to append the following:
74+
# commonLabels:
75+
# pixie-demo: px-k8ssandra
7376
kustomize build . > crd.yaml
7477
7578
k8ssandra-operator-root-dir $ cd config/deployments/control-plane/cluster-scope
79+
# Edit config/deployments/control-plane/cluster-scope/kustomization.yaml to append the following:
80+
# commonLabels:
81+
# pixie-demo: px-k8ssandra
7682
kustomize build . > k8ssandra-control-plane.yaml
7783
```
7884

0 commit comments

Comments
 (0)