From 6d9d709333b0001ab8ebc1bf2989a23c1304b1e6 Mon Sep 17 00:00:00 2001 From: Dom Del Nano Date: Fri, 8 Aug 2025 19:45:47 +0000 Subject: [PATCH 1/3] Upgrade Go to latest minor releases Signed-off-by: Dom Del Nano --- WORKSPACE | 6 +++--- bazel/pl_build_system.bzl | 2 +- go.mod | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index 70a50944a32..ff0cd59c4e6 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -33,7 +33,7 @@ pl_go_overrides() go_download_sdk( name = "go_sdk", - version = "1.24.4", + version = "1.24.6", ) go_rules_dependencies() @@ -212,7 +212,7 @@ gazelle_dependencies(go_sdk = "go_sdk") go_download_sdk( name = "go_sdk_1_23", - version = "1.23.10", + version = "1.23.12", ) # The go_sdk_boringcrypto SDK is used for testing boringcrypto specific functionality (TLS tracing). @@ -225,7 +225,7 @@ go_download_sdk( go_download_sdk( name = "go_sdk_boringcrypto", experiments = ["boringcrypto"], - version = "1.23.9", + version = "1.23.11", ) pip_parse( diff --git a/bazel/pl_build_system.bzl b/bazel/pl_build_system.bzl index e695b1f91e8..161784bd11b 100644 --- a/bazel/pl_build_system.bzl +++ b/bazel/pl_build_system.bzl @@ -23,7 +23,7 @@ load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library", "cc_test") load("@rules_python//python:defs.bzl", "py_test") load("//bazel:toolchain_transitions.bzl", "qemu_interactive_runner") -pl_boringcrypto_go_sdk = ["1.23.9"] +pl_boringcrypto_go_sdk = ["1.23.11"] pl_go_test_versions = ["1.18", "1.19", "1.20", "1.21", "1.22"] pl_supported_go_sdk_versions = ["1.23", "1.24"] diff --git a/go.mod b/go.mod index 8f5b78f2ca6..e88456ffa57 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module px.dev/pixie -go 1.24.4 +go 1.24.6 require ( cloud.google.com/go v0.81.0 From dd44e8148713b44936563ea54c623b9dd95a2e05 Mon Sep 17 00:00:00 2001 From: Dom Del Nano Date: Fri, 8 Aug 2025 20:03:57 +0000 Subject: [PATCH 2/3] Update docker images with new go version Signed-off-by: Dom Del Nano --- docker.properties | 8 ++++---- tools/chef/cookbooks/px_dev/attributes/linux.rb | 4 ++-- tools/chef/cookbooks/px_dev/attributes/mac_os_x.rb | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docker.properties b/docker.properties index 3ecd16e2653..e54e1ae7e8e 100644 --- a/docker.properties +++ b/docker.properties @@ -1,4 +1,4 @@ -DOCKER_IMAGE_TAG=202507242250 -LINTER_IMAGE_DIGEST=911f172364626f44efb61345517b5e7bb8c8ee8f065fcf3ba0a790ab1a88cdcb -DEV_IMAGE_DIGEST=08fc759c2b45078214be313335b8c3c23200aea54b9609e8c42fe367762e6c7c -DEV_IMAGE_WITH_EXTRAS_DIGEST=0ecefa696cfad238c432c2e213600263d00dda4ca4a427796f8fc16eb3d9bfc0 +DOCKER_IMAGE_TAG=202508081946 +LINTER_IMAGE_DIGEST=85a928e7607ef9c0c78f7aa421b04e328d5085bb1698bcf7eec1dcb6d609e3c8 +DEV_IMAGE_DIGEST=4a116347d80d330e978d57552a9a49258fd615912cd8f94398a2281bb7e362eb +DEV_IMAGE_WITH_EXTRAS_DIGEST=5b60b6fa4a98265da41a8ec4ec363bf946fd1b5d7b977d46bd6c6d941e183816 diff --git a/tools/chef/cookbooks/px_dev/attributes/linux.rb b/tools/chef/cookbooks/px_dev/attributes/linux.rb index 99857732ce5..ea92f2935ba 100644 --- a/tools/chef/cookbooks/px_dev/attributes/linux.rb +++ b/tools/chef/cookbooks/px_dev/attributes/linux.rb @@ -33,9 +33,9 @@ '648b599397548e4bb92429eec6391374c2cbb0edb835e3b3f03d4281c011f401' default['golang']['download_path'] = - 'https://go.dev/dl/go1.24.4.linux-amd64.tar.gz' + 'https://go.dev/dl/go1.24.6.linux-amd64.tar.gz' default['golang']['sha256'] = - '77e5da33bb72aeaef1ba4418b6fe511bc4d041873cbf82e5aa6318740df98717' + 'bbca37cc395c974ffa4893ee35819ad23ebb27426df87af92e93a9ec66ef8712' default['golangci-lint']['download_path'] = 'https://github.com/golangci/golangci-lint/releases/download/v2.0.2/golangci-lint-2.0.2-linux-amd64.tar.gz' diff --git a/tools/chef/cookbooks/px_dev/attributes/mac_os_x.rb b/tools/chef/cookbooks/px_dev/attributes/mac_os_x.rb index 77e4a8c79d3..aa6a8d4d8c3 100644 --- a/tools/chef/cookbooks/px_dev/attributes/mac_os_x.rb +++ b/tools/chef/cookbooks/px_dev/attributes/mac_os_x.rb @@ -34,9 +34,9 @@ '8d3709d957c7115610e764621569728be102d213fee15bc1d1aa9d465eb2c258' default['golang']['download_path'] = - 'https://go.dev/dl/go1.24.4.darwin-amd64.tar.gz' + 'https://go.dev/dl/go1.24.6.darwin-amd64.tar.gz' default['golang']['sha256'] = - '69bef555e114b4a2252452b6e7049afc31fbdf2d39790b669165e89525cd3f5c' + '4a8d7a32052f223e71faab424a69430455b27b3fff5f4e651f9d97c3e51a8746' default['golangci-lint']['download_path'] = 'https://github.com/golangci/golangci-lint/releases/download/v2.0.2/golangci-lint-2.0.2-darwin-amd64.tar.gz' From 1615f61f7ee1d971d860679cd5287fb5f57e2bce Mon Sep 17 00:00:00 2001 From: Dom Del Nano Date: Fri, 8 Aug 2025 22:11:50 +0000 Subject: [PATCH 3/3] Fix unit tests Signed-off-by: Dom Del Nano --- src/stirling/obj_tools/go_syms_test.cc | 2 +- .../dynamic_tracer/dynamic_tracing/dwarvifier_test.cc | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/stirling/obj_tools/go_syms_test.cc b/src/stirling/obj_tools/go_syms_test.cc index bf119eee990..187ca45f95d 100644 --- a/src/stirling/obj_tools/go_syms_test.cc +++ b/src/stirling/obj_tools/go_syms_test.cc @@ -58,7 +58,7 @@ TEST(ReadGoBuildInfoTest, BuildinfoEndianAgnostic) { ASSERT_OK_AND_ASSIGN(std::unique_ptr elf_reader, ElfReader::Create(kPath)); ASSERT_OK_AND_ASSIGN(auto pair, ReadGoBuildInfo(elf_reader.get())); auto version = pair.first; - EXPECT_THAT(version, StrEq("1.24.4")); + EXPECT_THAT(version, StrEq("1.24.6")); } TEST(ReadGoBuildInfoTest, BuildinfoLittleEndian) { diff --git a/src/stirling/source_connectors/dynamic_tracer/dynamic_tracing/dwarvifier_test.cc b/src/stirling/source_connectors/dynamic_tracer/dynamic_tracing/dwarvifier_test.cc index 97a4f670df0..27dce6fffd6 100644 --- a/src/stirling/source_connectors/dynamic_tracer/dynamic_tracing/dwarvifier_test.cc +++ b/src/stirling/source_connectors/dynamic_tracer/dynamic_tracing/dwarvifier_test.cc @@ -1820,28 +1820,28 @@ probes { scalar_var { name: "main__IntStruct_sym_addr1" type: UINT64 - constant: "5103904" + constant: "5104096" } } vars { scalar_var { name: "runtime__errorString_sym_addr2" type: UINT64 - constant: "5104192" + constant: "5104384" } } vars { scalar_var { name: "runtime__plainError_sym_addr3" type: UINT64 - constant: "5104224" + constant: "5104416" } } vars { scalar_var { name: "internal___poll__errNetClosing_sym_addr4" type: UINT64 - constant: "5104256" + constant: "5104448" } } vars {